<div dir="ltr">On 5 November 2013 16:21, Eric Anholt <span dir="ltr"><<a href="mailto:eric@anholt.net" target="_blank">eric@anholt.net</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
In the SIMD16 spilling changes, I replaced a "1" in the spill path with<br>
"mlen", but obviously it wasn't mlen before because spills have the g0<br>
header along with the payload. The interface I was trying to use was<br>
asking for how many physical regs we're writing, so we're looking for "1"<br>
or "2".<br>
<br>
I'm guessing this actually passed piglit because the high 8 bits of the<br>
execution mask in SIMD8 mode are all 0s.<br></blockquote><div><br></div><div>Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---<br>
src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp<br>
index 63ac530..83917f5 100644<br>
--- a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp<br>
+++ b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp<br>
@@ -757,7 +757,7 @@ fs_generator::generate_scratch_write(fs_inst *inst, struct brw_reg src)<br>
retype(brw_message_reg(inst->base_mrf + 1), BRW_REGISTER_TYPE_UD),<br>
retype(src, BRW_REGISTER_TYPE_UD));<br>
brw_oword_block_write_scratch(p, brw_message_reg(inst->base_mrf),<br>
- inst->mlen, inst->offset);<br>
+ dispatch_width / 8, inst->offset);<br>
}<br>
<br>
void<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.8.4.rc3<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>