<div dir="ltr">May I ask if those fixmes are actually fixed? Otherwise, wouldn't it be wiser to keep them pointing out this problems? </div><div class="gmail_extra"> <div class="gmail_quote">2013/12/4 Alex Deucher <<a href="mailto:alexdeucher@gmail.com" target="_blank">alexdeucher@gmail.com</a>> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Tue, Dec 3, 2013 at 11:38 PM, Michel Dänzer <<a href="mailto:michel@daenzer.net">michel@daenzer.net</a>> wrote: > From: Michel Dänzer <<a href="mailto:michel.daenzer@amd.com">michel.daenzer@amd.com</a>> > > Signed-off-by: Michel Dänzer <<a href="mailto:michel.daenzer@amd.com">michel.daenzer@amd.com</a>> </div>Reviewed-by: Alex Deucher <<a href="mailto:alexander.deucher@amd.com">alexander.deucher@amd.com</a>> <div class="HOEnZb"><div class="h5"> > --- > src/gallium/drivers/radeonsi/radeonsi_pipe.c | 1 - > src/gallium/drivers/radeonsi/radeonsi_shader.c | 5 +---- > 2 files changed, 1 insertion(+), 5 deletions(-) > > diff --git a/src/gallium/drivers/radeonsi/radeonsi_pipe.c b/src/gallium/drivers/radeonsi/radeonsi_pipe.c > index 0242a03..4aaa88f 100644 > --- a/src/gallium/drivers/radeonsi/radeonsi_pipe.c > +++ b/src/gallium/drivers/radeonsi/radeonsi_pipe.c > @@ -392,7 +392,6 @@ static int r600_get_param(struct pipe_screen* pscreen, enum pipe_cap param) > > /* Render targets. */ > case PIPE_CAP_MAX_RENDER_TARGETS: > - /* FIXME some r6xx are buggy and can only do 4 */ > return 8; > > case PIPE_CAP_MAX_VIEWPORTS: > diff --git a/src/gallium/drivers/radeonsi/radeonsi_shader.c b/src/gallium/drivers/radeonsi/radeonsi_shader.c > index 96cc1aa..88825bb 100644 > --- a/src/gallium/drivers/radeonsi/radeonsi_shader.c > +++ b/src/gallium/drivers/radeonsi/radeonsi_shader.c > @@ -281,7 +281,6 @@ static void declare_input_fs( > attr_number = lp_build_const_int32(gallivm, > shader->input[input_index].param_offset); > > - /* XXX: Handle all possible interpolation modes */ > switch (decl->Interp.Interpolate) { > case TGSI_INTERPOLATE_COLOR: > if (si_shader_ctx->shader->key.ps.flatshade) { > @@ -875,7 +874,7 @@ static void si_llvm_emit_streamout(struct si_shader_context *shader) > lp_build_endif(&if_ctx); > } > > -/* XXX: This is partially implemented for VS only at this point. It is not complete */ > + > static void si_llvm_emit_epilogue(struct lp_build_tgsi_context * bld_base) > { > struct si_shader_context * si_shader_ctx = si_shader_context(bld_base); > @@ -1222,8 +1221,6 @@ handle_semantic: > LLVMVoidTypeInContext(base->gallivm->context), > last_args, 9); > } > -/* XXX: Look up what this function does */ > -/* ctx->shader->output[i].spi_sid = r600_spi_sid(&ctx->shader->output[i]);*/ > } > > static const struct lp_build_tgsi_action txf_action; > -- > 1.8.4.3 > > _______________________________________________ > mesa-dev mailing list > <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> > <a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </div></div></blockquote></div> </div>