<div dir="ltr">On 24 November 2013 21:00, Francisco Jerez <span dir="ltr"><<a href="mailto:currojerez@riseup.net" target="_blank">currojerez@riseup.net</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">+<enum name="VERTEX_ATTRIB_ARRAY_BARRIER_BIT" value="0x00000001"/><br>
+<enum name="ELEMENT_ARRAY_BARRIER_BIT" value="0x00000002"/><br>
+<enum name="UNIFORM_BARRIER_BIT" value="0x00000004"/><br>
+<enum name="TEXTURE_FETCH_BARRIER_BIT" value="0x00000008"/><br>
+<enum name="SHADER_IMAGE_ACCESS_BARRIER_BIT" value="0x00000020"/><br>
+<enum name="COMMAND_BARRIER_BIT" value="0x00000040"/><br>
+<enum name="PIXEL_BUFFER_BARRIER_BIT" value="0x00000080"/><br>
+<enum name="TEXTURE_UPDATE_BARRIER_BIT" value="0x00000100"/><br>
+<enum name="BUFFER_UPDATE_BARRIER_BIT" value="0x00000200"/><br>
+<enum name="FRAMEBUFFER_BARRIER_BIT" value="0x00000400"/><br>
+<enum name="TRANSFORM_FEEDBACK_BARRIER_BIT" value="0x00000800"/><br>
+<enum name="ATOMIC_COUNTER_BARRIER_BIT" value="0x00001000"/><br>
+<enum name="ALL_BARRIER_BITS" value="0xFFFFFFFF"/><br>
+<enum name="MAX_IMAGE_UNITS" value="0x8F38"/><br>
+<enum name="MAX_COMBINED_IMAGE_UNITS_AND_FRAGMENT_OUTPUTS" value="0x8F39"/><br>
+<enum name="IMAGE_BINDING_NAME" value="0x8F3A"/><br>
+<enum name="IMAGE_BINDING_LEVEL" value="0x8F3B"/><br>
+<enum name="IMAGE_BINDING_LAYERED" value="0x8F3C"/><br>
+<enum name="IMAGE_BINDING_LAYERED_EXT" value="0x8F3C"/><br></blockquote><div><br></div><div>I'm surprised to see IMAGE_BINDING_LAYERED_EXT here instead of IMAGE_BINDING_LAYER.  I assume this was just a typographical error?<br>
<br>Change this line to:<br><br><enum name="IMAGE_BINDING_LAYER" value="0x8F3D"/><br><br>(note: the value also needs to change), and this patch is:<br><br>Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>></div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+<enum name="IMAGE_BINDING_ACCESS" value="0x8F3E"/><br>
+<enum name="IMAGE_1D" value="0x904C"/><br>
+<enum name="IMAGE_2D" value="0x904D"/><br>
+<enum name="IMAGE_3D" value="0x904E"/><br>
+<enum name="IMAGE_2D_RECT" value="0x904F"/><br>
+<enum name="IMAGE_CUBE" value="0x9050"/><br>
+<enum name="IMAGE_BUFFER" value="0x9051"/><br>
+<enum name="IMAGE_1D_ARRAY" value="0x9052"/><br>
+<enum name="IMAGE_2D_ARRAY" value="0x9053"/><br>
+<enum name="IMAGE_CUBE_MAP_ARRAY" value="0x9054"/><br>
+<enum name="IMAGE_2D_MULTISAMPLE" value="0x9055"/><br>
+<enum name="IMAGE_2D_MULTISAMPLE_ARRAY" value="0x9056"/><br>
+<enum name="INT_IMAGE_1D" value="0x9057"/><br>
+<enum name="INT_IMAGE_2D" value="0x9058"/><br>
+<enum name="INT_IMAGE_3D" value="0x9059"/><br>
+<enum name="INT_IMAGE_2D_RECT" value="0x905A"/><br>
+<enum name="INT_IMAGE_CUBE" value="0x905B"/><br>
+<enum name="INT_IMAGE_BUFFER" value="0x905C"/><br>
+<enum name="INT_IMAGE_1D_ARRAY" value="0x905D"/><br>
+<enum name="INT_IMAGE_2D_ARRAY" value="0x905E"/><br>
+<enum name="INT_IMAGE_CUBE_MAP_ARRAY" value="0x905F"/><br>
+<enum name="INT_IMAGE_2D_MULTISAMPLE" value="0x9060"/><br>
+<enum name="INT_IMAGE_2D_MULTISAMPLE_ARRAY" value="0x9061"/><br>
+<enum name="UNSIGNED_INT_IMAGE_1D" value="0x9062"/><br>
+<enum name="UNSIGNED_INT_IMAGE_2D" value="0x9063"/><br>
+<enum name="UNSIGNED_INT_IMAGE_3D" value="0x9064"/><br>
+<enum name="UNSIGNED_INT_IMAGE_2D_RECT" value="0x9065"/><br>
+<enum name="UNSIGNED_INT_IMAGE_CUBE" value="0x9066"/><br>
+<enum name="UNSIGNED_INT_IMAGE_BUFFER" value="0x9067"/><br>
+<enum name="UNSIGNED_INT_IMAGE_1D_ARRAY" value="0x9068"/><br>
+<enum name="UNSIGNED_INT_IMAGE_2D_ARRAY" value="0x9069"/><br>
+<enum name="UNSIGNED_INT_IMAGE_CUBE_MAP_ARRAY" value="0x906A"/><br>
+<enum name="UNSIGNED_INT_IMAGE_2D_MULTISAMPLE" value="0x906B"/><br>
+<enum name="UNSIGNED_INT_IMAGE_2D_MULTISAMPLE_ARRAY" value="0x906C"/><br>
+<enum name="MAX_IMAGE_SAMPLES" value="0x906D"/><br>
+<enum name="IMAGE_BINDING_FORMAT" value="0x906E"/><br>
+<enum name="IMAGE_FORMAT_COMPATIBILITY_TYPE" value="0x90C7"/><br>
+<enum name="IMAGE_FORMAT_COMPATIBILITY_BY_SIZE" value="0x90C8"/><br>
+<enum name="IMAGE_FORMAT_COMPATIBILITY_BY_CLASS" value="0x90C9"/><br>
+<enum name="MAX_VERTEX_IMAGE_UNIFORMS" value="0x90CA"/><br>
+<enum name="MAX_TESS_CONTROL_IMAGE_UNIFORMS" value="0x90CB"/><br>
+<enum name="MAX_TESS_EVALUATION_IMAGE_UNIFORMS" value="0x90CC"/><br>
+<enum name="MAX_GEOMETRY_IMAGE_UNIFORMS" value="0x90CD"/><br>
+<enum name="MAX_FRAGMENT_IMAGE_UNIFORMS" value="0x90CE"/><br>
+<enum name="MAX_COMBINED_IMAGE_UNIFORMS" value="0x90CF"/><br></blockquote></div></div></div>