<div dir="ltr">On 26 November 2013 00:02, Francisco Jerez <span dir="ltr"><<a href="mailto:currojerez@riseup.net" target="_blank">currojerez@riseup.net</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
+enum glsl_image_dim {<br>
+   GLSL_IMAGE_DIM_1D,<br>
+   GLSL_IMAGE_DIM_2D,<br>
+   GLSL_IMAGE_DIM_3D,<br>
+   GLSL_IMAGE_DIM_RECT,<br>
+   GLSL_IMAGE_DIM_CUBE,<br>
+   GLSL_IMAGE_DIM_BUFFER,<br>
+   GLSL_IMAGE_DIM_MS<br>
+};<br>
+<br></blockquote><div><br></div><div>glsl_image_dim seems redundant  with glsl_sampler_dim (they are identical except that the order is different, and glsl_sampler_dim includes the extra value GLSL_SAMPLER_DIM_EXTERNAL).  I'd prefer to just use one enum for both purposes, and don't create any image types using GLSL_SAMPLER_DIM_EXTERNAL.<br>
<br></div><div>With that changed, this patch is:<br><br>Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br></div></div></div></div>