<div dir="ltr">On 26 November 2013 00:02, Francisco Jerez <span dir="ltr"><<a href="mailto:currojerez@riseup.net" target="_blank">currojerez@riseup.net</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">---<br>
src/glsl/ast.h | 32 +++++++++++++++++++++++++++++++-<br>
src/glsl/ast_type.cpp | 5 +++++<br>
2 files changed, 36 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/src/glsl/ast.h b/src/glsl/ast.h<br>
index 5c214b6..b750bb7 100644<br>
--- a/src/glsl/ast.h<br>
+++ b/src/glsl/ast.h<br>
@@ -413,12 +413,23 @@ struct ast_type_qualifier {<br>
unsigned prim_type:1;<br>
unsigned max_vertices:1;<br>
/** \} */<br>
+<br>
+ /** \name Layout and memory qualifiers for ARB_shader_image_load_store. */<br>
+ /** \{ */<br>
+ unsigned early_fragment_tests:1;<br>
+ unsigned explicit_image_format:1;<br>
+ unsigned coherent:1;<br>
+ unsigned _volatile:1;<br>
+ unsigned _restrict:1;<br>
+ unsigned read_only:1;<br>
+ unsigned write_only:1;<br>
+ /** \} */<br></blockquote><div><br>As in patch 5, I'd like to see a comment next to "read_only" and "write_only" to indicate that they correspond to the GLSL keywords "readonly" and "writeonly".<br>
</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
}<br>
/** \brief Set of flags, accessed by name. */<br>
q;<br>
<br>
/** \brief Set of flags, accessed as a bitmask. */<br>
- unsigned i;<br>
+ uint64_t i;<br></blockquote><div><br>In glsl_parser.yy's "basic_interface_block" rule there are local variables called interface_type_mask and block_interface_qualifier that store values from ast_type_qualifier::flags.i. They should also be changed to uint64_t.<br>
<br></div><div>With those changes, this patch is:<br><br>Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br></div><br></div></div></div>