<div dir="ltr">On 2 December 2013 11:31, Francisco Jerez <span dir="ltr"><<a href="mailto:currojerez@riseup.net" target="_blank">currojerez@riseup.net</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">diff --git a/src/mesa/drivers/dri/i965/brw_program.c b/src/mesa/drivers/dri/i965/brw_program.c<br>
index 9a517be..a494bc2 100644<br>
--- a/src/mesa/drivers/dri/i965/brw_program.c<br>
+++ b/src/mesa/drivers/dri/i965/brw_program.c<br>
@@ -525,3 +525,31 @@ brw_destroy_shader_time(struct brw_context *brw)<br>
drm_intel_bo_unreference(brw-><a href="http://shader_time.bo" target="_blank">shader_time.bo</a>);<br>
brw-><a href="http://shader_time.bo" target="_blank">shader_time.bo</a> = NULL;<br>
}<br>
+<br>
+bool<br>
+brw_stage_prog_data_compare(const void *in_a, const void *in_b)<br>
+{<br>
+ const struct brw_stage_prog_data *a = in_a;<br>
+ const struct brw_stage_prog_data *b = in_b;<br></blockquote><div><br></div><div>Since this function is only called from the derived class compare funcs, it doesn't have to match the signature of cache_aux_compare_func. I'd prefer if we made the parameters const brw_stage_prog_data *'s and got a little extra type safety.<br>
<br>But I won't be a stickler about it. With or without the change, this patch is:<br><br>Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br></div></div></div></div>