<div dir="ltr">No piglit regressions on i965, or autotools based build regressions on ilo,nouveau,r300,r600 were observed as a result of these changes.<div> </div><div>Mark <div class="gmail_extra"> <div class="gmail_quote"> On Thu, Dec 19, 2013 at 1:56 PM, Mark Mueller <<a href="mailto:markkmueller@gmail.com" target="_blank">markkmueller@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> Adjust MESA_FORMAT color component ordering to match API docs, driver specific formats (e.g. PIPE_FORMATs), and actual use on common platforms. Add comment to reference API docs. Remove comments giving MESA_FORMAT color packings, some of which are misleading. The MESA_FORMAT changes are as follows: s/MESA_FORMAT_ARGB/MESA_FORMAT_BGRA/g s/MESA_FORMAT_ABGR/MESA_FORMAT_RGBA/g s/MESA_FORMAT_XRGB/MESA_FORMAT_BGRX/G MESA_FORMAT_XBGR was purposefully emitted because it exposes the redundant MESA_FORMAT_XBGR8888_SNORM and thus requires a more extensive patch which will be submitted separately. This patch apply on top of the previous MESA_FORMAT change. Signed-off-by: Mark Mueller <<a href="mailto:MarkKMueller@gmail.com">MarkKMueller@gmail.com</a>> --- src/gallium/state_trackers/dri/common/dri_screen.c | 4 +- src/mesa/drivers/dri/common/dri_util.c | 16 +- src/mesa/drivers/dri/common/utils.c | 16 +- src/mesa/drivers/dri/i915/i830_texstate.c | 8 +- src/mesa/drivers/dri/i915/i830_vtbl.c | 8 +- src/mesa/drivers/dri/i915/i915_context.c | 8 +- src/mesa/drivers/dri/i915/i915_texstate.c | 8 +- src/mesa/drivers/dri/i915/i915_vtbl.c | 8 +- src/mesa/drivers/dri/i915/intel_blit.c | 20 +-- src/mesa/drivers/dri/i915/intel_pixel_bitmap.c | 4 +- src/mesa/drivers/dri/i915/intel_screen.c | 10 +- src/mesa/drivers/dri/i915/intel_tex_image.c | 4 +- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 8 +- src/mesa/drivers/dri/i965/brw_context.c | 2 +- src/mesa/drivers/dri/i965/brw_surface_formats.c | 28 ++-- src/mesa/drivers/dri/i965/intel_blit.c | 12 +- src/mesa/drivers/dri/i965/intel_pixel_bitmap.c | 4 +- src/mesa/drivers/dri/i965/intel_screen.c | 8 +- src/mesa/drivers/dri/i965/intel_tex_image.c | 4 +- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 2 +- src/mesa/drivers/dri/nouveau/nouveau_fbo.c | 4 +- src/mesa/drivers/dri/nouveau/nouveau_screen.c | 4 +- src/mesa/drivers/dri/nouveau/nouveau_texture.c | 12 +- src/mesa/drivers/dri/nouveau/nouveau_util.h | 8 +- src/mesa/drivers/dri/nouveau/nv04_context.c | 2 +- src/mesa/drivers/dri/nouveau/nv04_state_fb.c | 4 +- src/mesa/drivers/dri/nouveau/nv04_state_frag.c | 2 +- src/mesa/drivers/dri/nouveau/nv04_state_raster.c | 2 +- src/mesa/drivers/dri/nouveau/nv04_state_tex.c | 8 +- src/mesa/drivers/dri/nouveau/nv04_surface.c | 56 +++---- src/mesa/drivers/dri/nouveau/nv10_state_fb.c | 4 +- src/mesa/drivers/dri/nouveau/nv10_state_frag.c | 4 +- src/mesa/drivers/dri/nouveau/nv10_state_tex.c | 14 +- src/mesa/drivers/dri/nouveau/nv20_state_fb.c | 4 +- src/mesa/drivers/dri/nouveau/nv20_state_tex.c | 16 +- src/mesa/drivers/dri/r200/r200_blit.c | 32 ++-- src/mesa/drivers/dri/r200/r200_state_init.c | 4 +- src/mesa/drivers/dri/r200/r200_texstate.c | 6 +- src/mesa/drivers/dri/radeon/radeon_blit.c | 24 +-- src/mesa/drivers/dri/radeon/radeon_pixel_read.c | 12 +- src/mesa/drivers/dri/radeon/radeon_screen.c | 16 +- src/mesa/drivers/dri/radeon/radeon_state_init.c | 4 +- src/mesa/drivers/dri/radeon/radeon_tex_copy.c | 4 +- src/mesa/drivers/dri/radeon/radeon_texstate.c | 6 +- src/mesa/drivers/dri/radeon/radeon_texture.c | 12 +- src/mesa/drivers/dri/swrast/swrast.c | 14 +- src/mesa/drivers/haiku/swrast/SoftwareRast.cpp | 6 +- src/mesa/drivers/osmesa/osmesa.c | 8 +- src/mesa/drivers/x11/xm_buffer.c | 6 +- src/mesa/main/debug.c | 2 +- src/mesa/main/fbobject.c | 2 +- src/mesa/main/format_pack.c | 94 +++++------ src/mesa/main/format_unpack.c | 54 +++--- src/mesa/main/formats.c | 114 ++++++------- src/mesa/main/formats.h | 183 ++++++++++----------- src/mesa/main/framebuffer.c | 2 +- src/mesa/main/readpix.c | 2 +- src/mesa/main/texcompress_etc.c | 2 +- src/mesa/main/texformat.c | 50 +++--- src/mesa/main/texstore.c | 72 ++++---- src/mesa/state_tracker/st_format.c | 44 ++--- src/mesa/swrast/s_drawpix.c | 12 +- src/mesa/swrast/s_texfetch.c | 28 ++-- src/mesa/swrast/s_texfetch_tmp.h | 18 +- 64 files changed, 579 insertions(+), 580 deletions(-) </blockquote></div></div></div></div>