<div dir="ltr">On 15 January 2014 02:46, Tapani <span dir="ltr"><<a href="mailto:tapani.palli@intel.com" target="_blank">tapani.palli@intel.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"><div class="im">
<div>On 01/14/2014 07:53 PM, Paul Berry
wrote:<br>
</div>
</div><blockquote type="cite">
<div dir="ltr"><div class="im">On 2 January 2014 03:58, Tapani Pälli <span dir="ltr"><<a href="mailto:tapani.palli@intel.com" target="_blank">tapani.palli@intel.com</a>></span>
wrote:<br>
</div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="im"><blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+static void<br>
+serialize_uniform_storage(gl_uniform_storage *uni,
memory_writer &blob)<br>
</blockquote>
<div><br>
</div>
<div>I don't think this is right. The
ARB_get_program_binary spec says:<br>
<br>
8. How does ProgramBinary interact with uniform
values, including<br>
shader-specified defaults?<br>
<br>
RESOLVED: All uniforms specified in the binary are
reset to their shader-<br>
specified defaults, or to zero if they aren't
specified, when the program<br>
binary is loaded. The spec language has been updated
to specify this<br>
behavior.<br>
<br>
</div>
<div>The OES_get_program_binary spec doesn't mention
uniforms at all, but I believe this is not intended to
indicate a behavioural difference--it's just a consequence
of the fact that ARB_get_program_binary was written later,
so they had a chance to clarify things. In fact, issue #7
in ARB_get_program_binary specifically says:<br>
<br>
7. How does this spec differ from the
OES_get_program_binary and why?<br>
<br>
...<br>
<br>
There are other areas where language was clarified,
but this is meant to<br>
be consistent with the intent of the original
specification and not to<br>
alter previously established behavior.<br>
<br>
</div>
<div>So I believe we shouldn't be serializing uniform
values.<br>
</div>
</div>
</div>
</div>
</blockquote>
<br></div></blockquote></div></div></div></blockquote>
For me this seemed much easier way to serialize than recreate it
though. Would it be enough if I reset the default values in place?</div></blockquote><div><br></div><div>Yes, I think that would be reasonable. Thanks!<br></div></div></div></div>