<div dir="ltr">On 20 December 2013 06:39, Topi Pohjolainen <span dir="ltr"><<a href="mailto:topi.pohjolainen@intel.com" target="_blank">topi.pohjolainen@intel.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp<br>
index df91235..4c159e6 100644<br>
--- a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp<br>
+++ b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp<br>
@@ -190,6 +190,21 @@ fs_generator::generate_fb_write(fs_inst *inst)<br>
    mark_surface_used(surf_index);<br>
 }<br>
<br>
+void<br>
+fs_generator::generate_blorp_fb_write(fs_inst *inst)<br>
+{<br>
+   brw_fb_WRITE(p,<br>
+                16 /* dispatch_width */,<br>
+                inst->base_mrf,<br>
+                brw_reg_from_fs_reg(&inst->src[0]),<br>
+                BRW_DATAPORT_RENDER_TARGET_WRITE_SIMD16_SINGLE_SOURCE,<br>
+                1 /* BRW_BLORP_RENDERBUFFER_BINDING_TABLE_INDEX */,<br></blockquote><div><br></div><div>This seems like it would lead to a maintenance burden if anyone ever decides to change BRW_BLORP_RENDERBUFFER_BINDING_TABLE_INDEX to a number other than 1.  Can we move the declaration of BRW_BLORP_RENDERBUFFER_BINDING_TABLE_INDEX to somewhere that's accessible to this file so that we can just pass it in directly?  Alternatively, we could store it in inst->target.<br>
<br></div><div>With that issue addressed, this patch is:<br><br>Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

+                inst->mlen,<br>
+                0,<br>
+                true,<br>
+                inst->header_present);<br>
+}<br>
+<br></blockquote></div></div></div>