<div dir="ltr">On 21 January 2014 04:19, Timothy Arceri <span dir="ltr"><<a href="mailto:t_arceri@yahoo.com.au" target="_blank">t_arceri@yahoo.com.au</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Signed-off-by: Timothy Arceri <<a href="mailto:t_arceri@yahoo.com.au">t_arceri@yahoo.com.au</a>><br>
---<br>
src/glsl/ast_to_hir.cpp | 6 ++++--<br>
1 file changed, 4 insertions(+), 2 deletions(-)<br></blockquote><div><br></div><div>Can you say more in the commit message about why you're making this change? Is this fixing an existing bug? Is it preparing for a later change (which would otherwise create a bug if the change weren't made)? Or are you doing it just because it seems reasonable to do?<br>
</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp<br>
index 326aa58..d02c9ff 100644<br>
--- a/src/glsl/ast_to_hir.cpp<br>
+++ b/src/glsl/ast_to_hir.cpp<br>
@@ -830,8 +830,10 @@ do_assignment(exec_list *instructions, struct _mesa_glsl_parse_state *state,<br>
rhs->type->array_size());<br>
d->type = var->type;<br>
}<br>
- mark_whole_array_access(rhs);<br>
- mark_whole_array_access(lhs);<br>
+ if (lhs->type->is_array()) {<br>
+ mark_whole_array_access(rhs);<br>
+ mark_whole_array_access(lhs);<br>
+ }<br>
}<br>
<br>
/* Most callers of do_assignment (assign, add_assign, pre_inc/dec,<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.8.3.1<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>