<div dir="ltr">On 21 January 2014 04:19, Timothy Arceri <span dir="ltr"><<a href="mailto:t_arceri@yahoo.com.au" target="_blank">t_arceri@yahoo.com.au</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Signed-off-by: Timothy Arceri <<a href="mailto:t_arceri@yahoo.com.au">t_arceri@yahoo.com.au</a>><br>
---<br>
src/mesa/main/extensions.c | 1 +<br>
src/mesa/main/mtypes.h | 1 +<br>
2 files changed, 2 insertions(+)<br></blockquote><div><br></div><div>Since this is a GLSL extension, you also need to update glcpp_parser_create() (in glcpp-parse.y) to call add_builtin_define(parser, "GL_ARB_arrays_of_arrays") if extensions->ARB_arrays_of_arrays is set.<br>
<br></div><div>With that fixed, this patch is:<br><br>Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br><br>Personally I would also add the extension to the _mesa_glsl_supported_extensions[] table in this patch, as well as add the bools ARB_arrays_of_arrays_enable and ARB_arrays_of_arrays_warn to _mesa_glsl_parse_state. I see you've done that as part of patch 3/8 instead. I suppose that's a matter of personal preference though.<br>
</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c<br>
index 2e0ccc3..95eb7ca 100644<br>
--- a/src/mesa/main/extensions.c<br>
+++ b/src/mesa/main/extensions.c<br>
@@ -80,6 +80,7 @@ static const struct extension extension_table[] = {<br>
/* ARB Extensions */<br>
{ "GL_ARB_ES2_compatibility", o(ARB_ES2_compatibility), GL, 2009 },<br>
{ "GL_ARB_ES3_compatibility", o(ARB_ES3_compatibility), GL, 2012 },<br>
+ { "GL_ARB_arrays_of_arrays", o(ARB_arrays_of_arrays), GL, 2012 },<br>
{ "GL_ARB_base_instance", o(ARB_base_instance), GL, 2011 },<br>
{ "GL_ARB_blend_func_extended", o(ARB_blend_func_extended), GL, 2009 },<br>
{ "GL_ARB_clear_buffer_object", o(dummy_true), GL, 2012 },<br>
diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h<br>
index 33df682..eef67a8 100644<br>
--- a/src/mesa/main/mtypes.h<br>
+++ b/src/mesa/main/mtypes.h<br>
@@ -3366,6 +3366,7 @@ struct gl_extensions<br>
GLboolean ANGLE_texture_compression_dxt;<br>
GLboolean ARB_ES2_compatibility;<br>
GLboolean ARB_ES3_compatibility;<br>
+ GLboolean ARB_arrays_of_arrays;<br>
GLboolean ARB_base_instance;<br>
GLboolean ARB_blend_func_extended;<br>
GLboolean ARB_color_buffer_float;<br>
<span class=""><font color="#888888">--<br>
1.8.3.1<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>