<div dir="ltr">On 22 January 2014 03:33, Timothy Arceri <span dir="ltr"><<a href="mailto:t_arceri@yahoo.com.au" target="_blank">t_arceri@yahoo.com.au</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Previously the reason we needed is_array was because we used array_size == NULL to<br>
represent both non-arrays and unsized arrays. Now that we use a non-NULL<br>
array_specifier to represent an unsized array, is_array is redundant.<br>
<br>
Signed-off-by: Timothy Arceri <<a href="mailto:t_arceri@yahoo.com.au" target="_blank">t_arceri@yahoo.com.au</a>><br>
---<br>
src/glsl/ast.h | 32 +++++++-------------------------<br>
src/glsl/ast_to_hir.cpp | 10 +++++-----<br>
src/glsl/ast_type.cpp | 6 ++----<br>
src/glsl/glsl_parser.yy | 30 +++++++++++++++---------------<br>
src/glsl/glsl_parser_extras.cpp | 15 ++++++---------<br>
5 files changed, 35 insertions(+), 58 deletions(-)<br></blockquote><div><br></div><div>When I try to build this patch I get the compile error:<br><br> CXX ast_to_hir.lo<br>../../src/glsl/ast_to_hir.cpp: In member function 'virtual ir_rvalue* ast_declarator_list::hir(exec_list*, _mesa_glsl_parse_state*)':<br>
../../src/glsl/ast_to_hir.cpp:2877:12: error: 'class ast_declaration' has no member named 'is_array'<br> assert(!decl->is_array);<br> ^<br><br></div><div>I'm guessing you missed this because you are building in release mode, so asserts didn't get compiled. If that's the case, I'd like to encourage you to do a debug build and double-check that piglit tests still pass. You can do that by adding the "--enable-debug" option when you run ./autogen.sh.<br>
<br><br></div><div>With that fixed, the series is:<br><br>Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br><br></div><div>I'll try to push my patch "glsl: Simplify aggregate type inference to prepare for ARB_arrays_of_arrays." within the next hour. Do you have commit access to Mesa or would you like me to push the series for you?<br>
</div></div></div></div>