<html><body><div style="color:#000; background-color:#fff; font-family:HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif;font-size:10pt">> I'm guessing you missed this because you are building in release mode, so asserts didn't get compiled. If that's the > case, I'd like to encourage you to do a debug build and double-check that piglit tests still pass. You can do that by > adding the "--enable-debug" option when you run ./autogen.sh.<br clear="none"><div style="display: block;" class="yahoo_quoted"><div style="font-family: HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif; font-size: 10pt;"><div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"><div class="y_msg_container"><div id="yiv2124990456"><div><div class="yiv2124990456yqt5711691011" id="yiv2124990456yqtfd30252"><div dir="ltr"><div class="yiv2124990456gmail_extra"><div
class="yiv2124990456gmail_quote"><div>
<br clear="none">Yes I didnt have --enable-debug set thanks for the tip. I've sent an updated patch and also rerun my piglit tests which caused two asserts to fail. I've sent a follow up patch for one in the ir code although I dont full understand that bit of code yet so advice welcome on that one if its not right.<br>The other one is in the i965 backend brw_vec4_visitor.cpp:type_size() an interface in the case statement has assert(0) but I think this one can wait until the linking/backend support is done. <br><br clear="none"></div><div>> I'll try to push my patch "glsl: Simplify aggregate type inference to prepare for ARB_arrays_of_arrays." > within the next hour. Do you have commit access to Mesa or would you like me to push the series for you?<br><br>I have commit access but feel free to push it for me if you like, I'll push it if you haven't already done so when I get home tonight (in around 8 hours).<br clear="none">
</div></div></div></div></div></div></div><br><br></div> </div> </div> </div> </div></body></html>