<div dir="ltr">Thanks Marek,<div>I sent out a new set of patches, otherwise there is a branch called NewStartAMF at fdo:~mmueller/mesa with everything in.</div><div><br></div><div>Mark</div></div><div class="gmail_extra"><br>
<br><div class="gmail_quote">On Sun, Jan 26, 2014 at 3:03 PM, Marek Olšák <span dir="ltr"><<a href="mailto:maraeo@gmail.com" target="_blank">maraeo@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Mark,<br>
<br>
I will do it if you send me a git link to your branch which merges<br>
cleanly and compiles successfully.<br>
<span class="HOEnZb"><font color="#888888"><br>
Marek<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
On Sun, Jan 26, 2014 at 10:27 PM, Brian Paul <<a href="mailto:brian.e.paul@gmail.com">brian.e.paul@gmail.com</a>> wrote:<br>
> On Sun, Jan 26, 2014 at 11:45 AM, Mark Mueller <<a href="mailto:markkmueller@gmail.com">markkmueller@gmail.com</a>><br>
> wrote:<br>
>><br>
>><br>
>><br>
>><br>
>> On Fri, Jan 24, 2014 at 2:50 AM, Marek Olšák <<a href="mailto:maraeo@gmail.com">maraeo@gmail.com</a>> wrote:<br>
>>><br>
>>> On Thu, Jan 23, 2014 at 8:36 PM, Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>><br>
>>> wrote:<br>
>>> > On 01/23/2014 11:19 AM, Mark Mueller wrote:<br>
>>> >> That works for sRGB, but what about other color spaces that may be<br>
>>> >> added in<br>
>>> >> the future? I'm fine with leaving that to another day and with using<br>
>>> >> the<br>
>>> >> _SRGB decoration, as you say.<br>
>>> ><br>
>>> > Oy. Let's not worry about things that hypothetically could be someday.<br>
>>> > We need to do what makes sense today.<br>
>>><br>
>>> Yeah, let's commit this. We can discuss the other things later,<br>
>>> including if SRGB should be a type or a modifier. The series is<br>
>>> already pretty good.<br>
>>><br>
>>> Marek<br>
>><br>
>><br>
>> I'm not sure if further acknowledgement is needed to push the series,<br>
>> but, either way, I'm not authorized to push these.<br>
><br>
><br>
> The series looks good to me too, but I'd also like to see the _UNORM8 -><br>
> _SRGB suffix change in a follow-up patch.<br>
><br>
> I tried applying the patch series to my local tree but it doesn't apply<br>
> cleanly. My recent "mesa: add missing ETC2_SRGB cases in formats.c" change,<br>
> and possibly others are at fault. Sorry.<br>
><br>
> If you can rebase the series on top of master I can apply them, unless Marek<br>
> beats me to it (I'm in the midst of traveling today).<br>
><br>
> -Brian<br>
><br>
</div></div></blockquote></div><br></div>