<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - main/shaderapi.c:407: detach_shader: Assertion `shProg->Shaders[j]->Type == 0x8B31 || shProg->Shaders[j]->Type == 0x8B30' failed." href="https://bugs.freedesktop.org/show_bug.cgi?id=74723#c6">Comment # 6</a> on <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - main/shaderapi.c:407: detach_shader: Assertion `shProg->Shaders[j]->Type == 0x8B31 || shProg->Shaders[j]->Type == 0x8B30' failed." href="https://bugs.freedesktop.org/show_bug.cgi?id=74723">bug 74723</a> from <a class="email" href="mailto:idr@freedesktop.org" title="Ian Romanick <idr@freedesktop.org>"> Ian Romanick</a> <pre>Comment on <a href="attachment.cgi?id=93676" name="attach_93676" title="update assertion for GS">attachment 93676</a> <a href="attachment.cgi?id=93676&action=edit" title="update assertion for GS">[details]</a> <a href='page.cgi?id=splinter.html&bug=74723&attachment=93676'>[review]</a> update assertion for GS Review of <a href="attachment.cgi?id=93676" name="attach_93676" title="update assertion for GS">attachment 93676</a> <a href="attachment.cgi?id=93676&action=edit" title="update assertion for GS">[details]</a> <a href='page.cgi?id=splinter.html&bug=74723&attachment=93676'>[review]</a>: ----------------------------------------------------------------- That patch looks good. I'm surprised we've never hit this before... seems we need a piglit test (since most developers use debug builds). Reviewed-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>> A good follow-up patch would remove the extra { } and fix the indentation. :)</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>