<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - pipe_loader_sw.c:64: undefined reference to `xlib_create_sw_winsys'" href="https://bugs.freedesktop.org/show_bug.cgi?id=75356#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - pipe_loader_sw.c:64: undefined reference to `xlib_create_sw_winsys'" href="https://bugs.freedesktop.org/show_bug.cgi?id=75356">bug 75356</a> from <a class="email" href="mailto:christian.prochaska@genode-labs.com" title="Christian Prochaska <christian.prochaska@genode-labs.com>"> Christian Prochaska</a> <pre>(In reply to <a href="show_bug.cgi?id=75356#c3">comment #3</a>) > Created <a href="attachment.cgi?id=94574" name="attach_94574" title="pipe-loader: wrap pipe_loader_sw_probe_xlib within HAVE_PIPE_LOADER_XLIB">attachment 94574</a> <a href="attachment.cgi?id=94574&action=edit" title="pipe-loader: wrap pipe_loader_sw_probe_xlib within HAVE_PIPE_LOADER_XLIB">[details]</a> <a href='page.cgi?id=splinter.html&bug=75356&attachment=94574'>[review]</a> [review] > pipe-loader: wrap pipe_loader_sw_probe_xlib within HAVE_PIPE_LOADER_XLIB > > The patch description does not directly relate to the build log, as I have > chosen to fix the problem rather than putting ducktape over it. > > Note: The gallium/tests/trivial will segfault due to use of asserts over > proper error handling. > > Patch is working like a charm here, please give it a test as it's a bit more > evasive than I would like. > -Emil With the following addition, it could also compile without X headers: diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c b/src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c index 78b465b..17c2874 100644 --- a/src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c +++ b/src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c @@ -31,7 +31,9 @@ #include "util/u_dl.h" #include "sw/dri/dri_sw_winsys.h" #include "sw/null/null_sw_winsys.h" +#ifdef HAVE_PIPE_LOADER_XLIB #include "sw/xlib/xlib_sw_winsys.h" +#endif #include "target-helpers/inline_sw_helper.h" #include "state_tracker/drisw_api.h"</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>