<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - [swrast] piglit glsl-kwin-blur-1 regression" href="https://bugs.freedesktop.org/show_bug.cgi?id=78318#c1">Comment # 1</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - [swrast] piglit glsl-kwin-blur-1 regression" href="https://bugs.freedesktop.org/show_bug.cgi?id=78318">bug 78318</a> from <a class="email" href="mailto:kenneth@whitecape.org" title="Kenneth Graunke <kenneth@whitecape.org>"> Kenneth Graunke</a> <pre>This is the first broken commit: commit ca21cffebd063354291d561eadc2ded8795a5333 Author: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>> Date: Tue Mar 25 18:34:31 2014 -0700 meta: Fix saving the program pipeline state This code was broken in some odd ways before. Too much state was being saved, it was being restored in the wrong order, and in the wrong way. The biggest problem was that the pipeline object was restored before restoring the programs attached to the default pipeline. Fixes a regression in the glean texgen test. v3: Fairly significant re-write. I think it's much cleaner now, and it avoids a bug with some meta ops that use shaders (reported by Chia-I). v4: Check Pipeline.Current against NULL instead of Pipeline.Default. Suggested by Chia-I. Signed-off-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>> Reviewed-by: Chia-I Wu <<a href="mailto:olv@lunarg.com">olv@lunarg.com</a>> The test passes with the previous commit. With this commit, Mesa fails to build due to a missing } in meta.c, but with that fixed, the test fails.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>