<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jul 18, 2014 at 7:59 AM, Brian Paul <span dir="ltr"><<a href="mailto:brianp@vmware.com" target="_blank">brianp@vmware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On 07/17/2014 12:04 PM, Jason Ekstrand wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Before it was only storing one of the color components due to truncation.<br>
With this patch it now properly stores all of them.<br>
<br>
Signed-off-by: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com" target="_blank">jason.ekstrand@intel.com</a>><br>
---<br>
src/mesa/main/format_pack.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/mesa/main/format_pack.c b/src/mesa/main/format_pack.c<br>
index fb3feb5..4b52405 100644<br>
--- a/src/mesa/main/format_pack.c<br>
+++ b/src/mesa/main/format_pack.c<br>
@@ -856,7 +856,7 @@ pack_float_R_UNORM8(const GLfloat src[4], void *dst)<br>
static void<br>
pack_ubyte_R8G8_UNORM(const GLubyte src[4], void *dst)<br>
{<br>
- GLubyte *d = ((GLubyte *) dst);<br>
+ GLushort *d = ((GLushort *) dst);<br>
*d = PACK_COLOR_88(src[GCOMP], src[RCOMP]);<br>
}<br>
<br>
<br>
</blockquote>
<br></div></div>
Reviewed-by: Brian Paul <<a href="mailto:brianp@vmware.com" target="_blank">brianp@vmware.com</a>><br>
<br>
Should probably be tagged for the stable branch too.<br></blockquote><div><br></div><div>Yeah, I've already tweaked the commit message locally to CC mesa-stable.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
______________________________<u></u>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/<u></u>mailman/listinfo/mesa-dev</a><br>
</blockquote></div><br></div></div>