<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - wrong color in flightgear for the c172p if "Atmospheric light scattering" is used"
href="https://bugs.freedesktop.org/show_bug.cgi?id=81500#c22">Comment # 22</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - wrong color in flightgear for the c172p if "Atmospheric light scattering" is used"
href="https://bugs.freedesktop.org/show_bug.cgi?id=81500">bug 81500</a>
from <span class="vcard"><a class="email" href="mailto:imirkin@alum.mit.edu" title="Ilia Mirkin <imirkin@alum.mit.edu>"> <span class="fn">Ilia Mirkin</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=81500#c21">comment #21</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=81500#c20">comment #20</a>)
> >
> > Just a word of caution -- the fix might have been to a different part of the
> > code, and not to that particular file. You can use bisect again to figure
> > out the change that fixed it, just reverse the meanings of 'good' and 'bad'.
> > A "good" commit would be one that has the issue, and a "bad" commit would be
> > one where the issue is resolved. Then the first "bad" commit will point you
> > at the commit that resolves the problem.
>
> I did this type of bisect,
>
> and I managed to find the commit in 10.3.x who solves the bug : it's the
> commit 1d9f74eda75da05b4d5c7df5fc1e6f5ab8d88322 :
>
> <a href="http://cgit.freedesktop.org/mesa/mesa/commit/">http://cgit.freedesktop.org/mesa/mesa/commit/</a>
> ?id=1d9f74eda75da05b4d5c7df5fc1e6f5ab8d88322&utm_source=anzwix
>
> the good news is that if I apply the patch of this commit with 10.2.4 source
> code then the bug is solved,
>
> Do you think is it safe to push this commit in 10.2 branch of mesa ?
>
> for me it seems ok but I didn't do the piglit tests</span >
>From what I can see, this commit has nothing to do with any issues introduced
by the originally bad commit... this will require some investigation.
Summary:
apitrace:
<a href="http://demo.ovh.eu/download/365b2f85df30b16ec7539d7b9622542a/fgfs.tar.bz2">http://demo.ovh.eu/download/365b2f85df30b16ec7539d7b9622542a/fgfs.tar.bz2</a>
first bad commit: d030a3404ca0fedf365cb0fd41eaad7abc8ff132
commit that "fixes" it on master: 1d9f74eda75da05b4d5c7df5fc1e6f5ab8d88322</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>