<div dir="ltr">Reviewed-by: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com">jason.ekstrand@intel.com</a>><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jul 30, 2014 at 6:28 PM, Anuj Phogat <span dir="ltr"><<a href="mailto:anuj.phogat@gmail.com" target="_blank">anuj.phogat@gmail.com</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">V2: Â Declare the function in teximage.h<br> <div class=""><br> Cc: <<a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.org</a>><br> Signed-off-by: Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>><br> ---<br> </div>Â src/mesa/main/teximage.c | 12 ++++++------<br> Â src/mesa/main/teximage.h | Â 3 +++<br> <div class="">Â 2 files changed, 9 insertions(+), 6 deletions(-)<br> <br> </div>diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c<br> index a069594..6532e5b 100644<br> --- a/src/mesa/main/teximage.c<br> +++ b/src/mesa/main/teximage.c<br> @@ -1769,9 +1769,9 @@ compressedteximage_only_format(const struct gl_context *ctx, GLenum format)<br> <div class="">Â * Helper function to determine whether a target and specific compression<br> Â * format are supported.<br> Â */<br> -static GLboolean<br> -target_can_be_compressed(const struct gl_context *ctx, GLenum target,<br> - Â Â Â Â Â Â Â Â Â Â Â Â GLenum intFormat)<br> +GLboolean<br> +_mesa_target_can_be_compressed(const struct gl_context *ctx, GLenum target,<br> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â GLenum intFormat)<br> Â {<br> Â Â (void) intFormat; Â /* not used yet */<br> <br> </div>@@ -2193,7 +2193,7 @@ texture_error_check( struct gl_context *ctx,<br> <div class=""><br> Â Â /* additional checks for compressed textures */<br> Â Â if (_mesa_is_compressed_format(ctx, internalFormat)) {<br> - Â Â Â if (!target_can_be_compressed(ctx, target, internalFormat)) {<br> + Â Â Â if (!_mesa_target_can_be_compressed(ctx, target, internalFormat)) {<br> Â Â Â Â Â _mesa_error(ctx, GL_INVALID_ENUM,<br> Â Â Â Â Â Â Â Â Â Â Â "glTexImage%dD(target can't be compressed)", dimensions);<br> Â Â Â Â Â return GL_TRUE;<br> </div>@@ -2279,7 +2279,7 @@ compressed_texture_error_check(struct gl_context *ctx, GLint dimensions,<br> <div class="">Â Â GLenum error = GL_NO_ERROR;<br> Â Â char *reason = ""; /* no error */<br> <br> - Â if (!target_can_be_compressed(ctx, target, internalFormat)) {<br> + Â if (!_mesa_target_can_be_compressed(ctx, target, internalFormat)) {<br> Â Â Â Â reason = "target";<br> Â Â Â Â error = GL_INVALID_ENUM;<br> Â Â Â Â goto error;<br> </div>@@ -2720,7 +2720,7 @@ copytexture_error_check( struct gl_context *ctx, GLuint dimensions,<br> <div class="">Â Â }<br> <br> Â Â if (_mesa_is_compressed_format(ctx, internalFormat)) {<br> - Â Â Â if (!target_can_be_compressed(ctx, target, internalFormat)) {<br> + Â Â Â if (!_mesa_target_can_be_compressed(ctx, target, internalFormat)) {<br> Â Â Â Â Â _mesa_error(ctx, GL_INVALID_ENUM,<br> Â Â Â Â Â Â Â Â Â Â Â "glCopyTexImage%dD(target)", dimensions);<br> Â Â Â Â Â return GL_TRUE;<br> </div>diff --git a/src/mesa/main/teximage.h b/src/mesa/main/teximage.h<br> index dd1504b..b66a55b 100644<br> --- a/src/mesa/main/teximage.h<br> +++ b/src/mesa/main/teximage.h<br> @@ -123,6 +123,9 @@ _mesa_test_proxy_teximage(struct gl_context *ctx, GLenum target, GLint level,<br> Â Â Â Â Â Â Â Â Â Â Â Â Â Â mesa_format format,<br> Â Â Â Â Â Â Â Â Â Â Â Â Â Â GLint width, GLint height, GLint depth, GLint border);<br> <div class=""><br> +extern GLboolean<br> +_mesa_target_can_be_compressed(const struct gl_context *ctx, GLenum target,<br> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â GLenum intFormat);<br> <br> </div>Â extern GLuint<br> Â _mesa_tex_target_to_face(GLenum target);<br> <span class="HOEnZb"><font color="#888888">--<br> 1.9.3<br> <br> </font></span></blockquote></div><br></div>