<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Aug 1, 2014 at 6:48 AM, Neil Roberts <span dir="ltr"><<a href="mailto:neil@linux.intel.com" target="_blank">neil@linux.intel.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> writes:<br>
<br>
> +bool<br>
> +_mesa_meta_CopyImageSubData_uncompressed(struct gl_context *ctx,<br>
> +                                         struct gl_texture_image *src_tex_image,<br>
> +                                         int src_x, int src_y, int src_z,<br>
> +                                         struct gl_texture_image *dst_tex_image,<br>
> +                                         int dst_x, int dst_y, int dst_z,<br>
> +                                         int src_width, int src_height)<br>
> +{<br>
> +   GLuint src_view_texture = 0;<br>
> +   struct gl_texture_image *src_view_tex_image;<br>
> +   GLuint fbos[2];<br>
<br>
</div>...<br>
<br>
> +   _mesa_GenFramebuffers(2, fbos);<br>
<br>
...<br>
<div class=""><br>
> +cleanup:<br>
> +   _mesa_DeleteTextures(1, &src_view_texture);<br>
> +<br>
> +   return success;<br>
> +}<br>
<br>
</div>It looks like the two FBOs are leaked. Maybe they should be added to the<br>
cleanup step?<br></blockquote><div><br></div><div>Done.  Other than that, does this count as a R-B?<br></div><div>--Jason<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<br>
Regards,<br>
- Neil<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div><br></div></div>