<div dir="ltr"><div>Sorry, said that just a little early. Do we really want 4 bits for a floating-point format? How many bits does nvidia report?<br></div>--Jason<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Wed, Aug 6, 2014 at 9:55 AM, Jason Ekstrand <span dir="ltr"><<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div>This looks fine to me.<br></div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com" target="_blank">jason.ekstrand@intel.com</a>><br></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra">
<br><br><div class="gmail_quote">
On Wed, Aug 6, 2014 at 9:27 AM, Neil Roberts <span dir="ltr"><<a href="mailto:neil@linux.intel.com" target="_blank">neil@linux.intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Adds the ‘bptc’ layout to get_channel_bits. The channel bits for BPTC depend<br>
on the mode but as it only has to be an approximation we can set it to 4 like<br>
for S3TC.<br>
---<br>
src/mesa/main/format_info.py | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/mesa/main/format_info.py b/src/mesa/main/format_info.py<br>
index a0eecd3..fc40dc4 100644<br>
--- a/src/mesa/main/format_info.py<br>
+++ b/src/mesa/main/format_info.py<br>
@@ -110,7 +110,7 @@ def get_channel_bits(fmat, chan_name):<br>
if fmat.is_compressed():<br>
# These values are pretty-much bogus, but OpenGL requires that we<br>
# return an "approximate" number of bits.<br>
- if fmat.layout == 's3tc':<br>
+ if fmat.layout in ('s3tc', 'bptc'):<br>
return 4 if fmat.has_channel(chan_name) else 0<br>
elif fmat.layout == 'fxt1':<br>
if chan_name in 'rgb':<br>
<span><font color="#888888">--<br>
1.9.3<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>
</div></div></blockquote></div><br></div>