<div dir="ltr"><div>Brian,<br>Did you want to look over these or should I try and find someone else to review them? I'm most concerned with the 565 and 5551 patches since those touch corners of mesa with which I am very unfamiliar.<br></div>--Jason<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Aug 23, 2014 at 3:27 PM, Jason Ekstrand <span dir="ltr"><<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>One more note: I tested these on i965, llvmpipe, and swrast on both my laptop and my desktop. No changes on i965. A couple changes on llvmpipe on my desktop which I can't reproduce on my laptop. I think that's my desktop being funny. There seems to be one little issue still on swrast with RGB4 renderbuffers (which get mapped to 565). Unfortunately, I haven't been able to track that down. It's probably some place where the format conversion code is repeated.<span class="HOEnZb"><font color="#888888"><br>
</font></span></div><span class="HOEnZb"><font color="#888888"><div>--Jason<br></div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Aug 23, 2014 at 3:23 PM, Jason Ekstrand <span dir="ltr"><<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I needed a break from the i965 compiler backend, so I wrote some more<br>
format conversion patches. A lot of these are bug fixes or stand-alones.<br>
However, the last three require all the previous ones.<br>
<br>
Jason Ekstrand (8):<br>
main/format_util: Fix a bug in one of the format helper functions<br>
main: Fix packing/unpacking of MESA_FORMAT_R5G6B5_UNORM<br>
main/colormac: Remove an unused macro<br>
main: Fix A1R5G5B5 packing/unpacking<br>
mesa/format_utils: Prefix and expose the conversion helper functions<br>
main: Autogenerate most of format_pack.c<br>
MAYBEREVERT: Fill X components with 1<br>
main: Autogenerate format_unpack.c<br>
<br>
src/mesa/Makefile.am | 18 +<br>
src/mesa/Makefile.sources | 4 +-<br>
src/mesa/main/colormac.h | 3 -<br>
src/mesa/main/format_convert.py | 72 +<br>
src/mesa/main/format_pack.c | 18 +-<br>
src/mesa/main/format_pack.c.mako | 900 ++++++++<br>
src/mesa/main/format_unpack.c | 4329 ------------------------------------<br>
src/mesa/main/format_unpack.c.mako | 883 ++++++++<br>
src/mesa/main/format_utils.c | 215 +-<br>
src/mesa/main/format_utils.h | 105 +<br>
src/mesa/main/formats.c | 14 +-<br>
src/mesa/main/run_mako.py | 7 +<br>
src/mesa/main/texstore.c | 2 +-<br>
src/mesa/swrast/s_texfetch_tmp.h | 16 +-<br>
14 files changed, 2061 insertions(+), 4525 deletions(-)<br>
create mode 100644 src/mesa/main/format_convert.py<br>
create mode 100644 src/mesa/main/format_pack.c.mako<br>
delete mode 100644 src/mesa/main/format_unpack.c<br>
create mode 100644 src/mesa/main/format_unpack.c.mako<br>
create mode 100644 src/mesa/main/run_mako.py<br>
<span><font color="#888888"><br>
--<br>
2.1.0<br>
<br>
</font></span></blockquote></div><br></div>
</div></div></blockquote></div><br></div>