<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Glyphy demo throws unhandled Integer division by zero exception"
href="https://bugs.freedesktop.org/show_bug.cgi?id=83570#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Glyphy demo throws unhandled Integer division by zero exception"
href="https://bugs.freedesktop.org/show_bug.cgi?id=83570">bug 83570</a>
from <span class="vcard"><a class="email" href="mailto:sroland@vmware.com" title="Roland Scheidegger <sroland@vmware.com>"> <span class="fn">Roland Scheidegger</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=83570#c10">comment #10</a>)
<span class="quote">> Could be totally borked, but this is what I have at the moment:
>
> if (type.floating) {
> return LLVMBuildFDiv(builder, a, b, "");
> }
> else {
> //The spec says divide by zero is undefined, but shouldn't throw an
> exception
> LLVMValueRef zeromask = lp_build_cmp(bld,
> PIPE_FUNC_EQUAL,
> b,
> lp_build_zero(bld->gallivm,type));
> if (type.sign) {
> return lp_build_select(bld,
> zeromask,
> bld->undef,
> LLVMBuildSDiv(builder, a, b, ""));
> }
> else {
> return lp_build_select(bld,
> zeromask,
> bld->undef,
> LLVMBuildUDiv(builder, a, b, ""));
> }
> }
>
> I'll take a look at udiv_emit_cpu</span >
Hmm that can't quite work since you still do the division by zero, you just
don't use the result in the end.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>