<div dir="ltr">Reviewed-by: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com">jason.ekstrand@intel.com</a>><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 15, 2014 at 11:28 PM, Dave Airlie <span dir="ltr"><<a href="mailto:airlied@gmail.com" target="_blank">airlied@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Richard Sandiford <<a href="mailto:rsandifo@linux.vnet.ibm.com">rsandifo@linux.vnet.ibm.com</a>><br>
<br>
MESA_FORMAT_R8G8B8X8_SNORM used a function called unpack_X8B8G8R8_SNORM<br>
while MESA_FORMAT_R8G8B8X8_SRGB used a function called unpack_R8G8B8X8_SRGB.<br>
This patch renames the SNORM function to have the same order as the<br>
MESA_FORMAT name, like the SRGB function does.<br>
<br>
Signed-off-by: Richard Sandiford <<a href="mailto:rsandifo@linux.vnet.ibm.com">rsandifo@linux.vnet.ibm.com</a>><br>
Signed-off-by: Dave Airlie <<a href="mailto:airlied@redhat.com">airlied@redhat.com</a>><br>
---<br>
src/mesa/main/format_unpack.c | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/mesa/main/format_unpack.c b/src/mesa/main/format_unpack.c<br>
index eed92d8..68fbcb3 100644<br>
--- a/src/mesa/main/format_unpack.c<br>
+++ b/src/mesa/main/format_unpack.c<br>
@@ -2106,7 +2106,7 @@ unpack_XRGB1555_UNORM(const void *src, GLfloat dst[][4], GLuint n)<br>
}<br>
<br>
static void<br>
-unpack_XBGR8888_SNORM(const void *src, GLfloat dst[][4], GLuint n)<br>
+unpack_R8G8B8X8_SNORM(const void *src, GLfloat dst[][4], GLuint n)<br>
{<br>
const GLuint *s = ((const GLuint *) src);<br>
GLuint i;<br>
@@ -2526,7 +2526,7 @@ get_unpack_rgba_function(mesa_format format)<br>
<br>
table[MESA_FORMAT_B4G4R4X4_UNORM] = unpack_XRGB4444_UNORM;<br>
table[MESA_FORMAT_B5G5R5X1_UNORM] = unpack_XRGB1555_UNORM;<br>
- table[MESA_FORMAT_R8G8B8X8_SNORM] = unpack_XBGR8888_SNORM;<br>
+ table[MESA_FORMAT_R8G8B8X8_SNORM] = unpack_R8G8B8X8_SNORM;<br>
table[MESA_FORMAT_R8G8B8X8_SRGB] = unpack_R8G8B8X8_SRGB;<br>
table[MESA_FORMAT_RGBX_UINT8] = unpack_XBGR8888_UINT;<br>
table[MESA_FORMAT_RGBX_SINT8] = unpack_XBGR8888_SINT;<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.9.3<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>