<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - UE4: Realistic Rendering Demo render blue"
href="https://bugs.freedesktop.org/show_bug.cgi?id=84145#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - UE4: Realistic Rendering Demo render blue"
href="https://bugs.freedesktop.org/show_bug.cgi?id=84145">bug 84145</a>
from <span class="vcard"><a class="email" href="mailto:imirkin@alum.mit.edu" title="Ilia Mirkin <imirkin@alum.mit.edu>"> <span class="fn">Ilia Mirkin</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=84145#c6">comment #6</a>)
<span class="quote">> Ilia, any ideas?</span >
Oh neat. I was seeing that render blue as well, but was assuming it was due to
some spill errors that I had only semi-fixed.
The interesting thing to note is that the commit in question doesn't actually
enable ARB_texture_view on any driver, just sets the stage for it.
My guess is that it's due to the st_format.c hunk, but I can't imagine why. Oh
hrm. Perhaps this hunk, I can't remember what that did, but it seems
potentially dodgy:
@@ -970,7 +971,10 @@ st_GetTexImage(struct gl_context * ctx,
* - Luminance alpha must be returned as (L,0,0,A).
* - Intensity must be returned as (I,0,0,1)
*/
- src_format = util_format_linear(src->format);
+ if (stObj->surface_based)
+ src_format = util_format_linear(stObj->surface_format);
+ else
+ src_format = util_format_linear(src->format);
src_format = util_format_luminance_to_red(src_format);
src_format = util_format_intensity_to_red(src_format);</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>