<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 28, 2014 at 8:10 PM, Matt Turner <span dir="ltr"><<a href="mailto:mattst88@gmail.com" target="_blank">mattst88@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The spec says the type must be W (JIP is 16-bits after all), but we've<br>
been emitting it with a UD type all along and have experienced no<br>
adverse effects. Changing the type to D allows ELSE and ENDIF<br>
instructions to be compacted.<br>
---<br>
src/mesa/drivers/dri/i965/brw_eu_emit.c | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c b/src/mesa/drivers/dri/i965/brw_eu_emit.c<br>
index 937257b..15e1da7 100644<br>
--- a/src/mesa/drivers/dri/i965/brw_eu_emit.c<br>
+++ b/src/mesa/drivers/dri/i965/brw_eu_emit.c<br>
@@ -1496,7 +1496,7 @@ brw_ELSE(struct brw_compile *p)<br>
} else if (brw->gen == 7) {<br>
brw_set_dest(p, insn, retype(brw_null_reg(), BRW_REGISTER_TYPE_D));<br>
brw_set_src0(p, insn, retype(brw_null_reg(), BRW_REGISTER_TYPE_D));<br>
- brw_set_src1(p, insn, brw_imm_ud(0));<br>
+ brw_set_src1(p, insn, brw_imm_d(0));<br></blockquote><div><br></div><div>If it requires W, why are we emitting it with type D? I guess it shouldn't make any difference for a small immediate.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
brw_inst_set_jip(brw, insn, 0);<br>
brw_inst_set_uip(brw, insn, 0);<br>
} else {<br>
@@ -1573,7 +1573,7 @@ brw_ENDIF(struct brw_compile *p)<br>
} else if (brw->gen == 7) {<br>
brw_set_dest(p, insn, retype(brw_null_reg(), BRW_REGISTER_TYPE_D));<br>
brw_set_src0(p, insn, retype(brw_null_reg(), BRW_REGISTER_TYPE_D));<br>
- brw_set_src1(p, insn, brw_imm_ud(0));<br>
+ brw_set_src1(p, insn, brw_imm_d(0));<br>
} else {<br>
brw_set_src0(p, insn, brw_imm_d(0));<br>
}<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.8.5.5<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>