<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Unify the format conversion code" href="https://bugs.freedesktop.org/show_bug.cgi?id=84566#c3">Comment # 3</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Unify the format conversion code" href="https://bugs.freedesktop.org/show_bug.cgi?id=84566">bug 84566</a> from <a class="email" href="mailto:itoral@igalia.com" title="Iago Toral <itoral@igalia.com>"> Iago Toral</a> <pre>(In reply to Jason Ekstrand from <a href="show_bug.cgi?id=84566#c0">comment #0</a>) (...) > 5) Make a masater conversion function that takes a void*, format, width, > height, and stride for both source and destination and just does the > conversion. If the above mentioned array format enum is distinct from the > mesa_format enum, the function could be written to take a uint32_t type and > accept either mesa_format or an array format in the same parameter. > 6) Use the above master conversion function for TexSubimage, TexImage, > GetTexImage, DrawPixels, and ReadPixels. We still have to deal with pixel > conversion, but it should vastly simplify all of them. As far as I can see, functions in textstore do not receive a mesa_format for their src argument, instead they receive the GL format and data type, so in order to use the master function here we need to map this combination to a mesa_format or mesa_array_format first. It does not look like this conversion is available anywhere though, so I think we need to create a function that maps (GLformat, GLDataType)-> mesa_format. Something similar to what _mesa_format_to_type_and_comps does, but the other way around. Jason, does this make sense to you?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>