<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Unify the format conversion code" href="https://bugs.freedesktop.org/show_bug.cgi?id=84566#c18">Comment # 18</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Unify the format conversion code" href="https://bugs.freedesktop.org/show_bug.cgi?id=84566">bug 84566</a> from <a class="email" href="mailto:itoral@igalia.com" title="Iago Toral <itoral@igalia.com>"> Iago Toral</a> <pre>(In reply to Jason Ekstrand from <a href="show_bug.cgi?id=84566#c17">comment #17</a>) > (In reply to Iago Toral from <a href="show_bug.cgi?id=84566#c16">comment #16</a>) > > We also need new mesa_format enums and pack/unpack functions for byte > > swapped variants of non-array types. > > Why? Is this for the byte_swapped flag on GL upload/downloads? If that's > the only reason, then I'd rather not bother adding mesa types. We can > easily do a byte swap with _mesa_swizzle_and_convert. While it's a little > bit of a performance hit, people shouldn't be using that attribute anyway. I think that won't help in this case. We can only use _mesa_swizzle_and_convert for array types, but as I say, this involves non-array types like GL_UNSIGNED_INT_10_10_10_2. The master converter will not use _mesa_swizzle_and_convert with these, it goes through things like _mesa_unpack_rgba_row and _mesa_pack_float_rgba_row for example (which rely on auto-generated pack/unpack functions). Do you think we should try expand these to consider byte-swapping?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>