<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Unify the format conversion code"
href="https://bugs.freedesktop.org/show_bug.cgi?id=84566#c41">Comment # 41</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Unify the format conversion code"
href="https://bugs.freedesktop.org/show_bug.cgi?id=84566">bug 84566</a>
from <span class="vcard"><a class="email" href="mailto:jason@jlekstrand.net" title="Jason Ekstrand <jason@jlekstrand.net>"> <span class="fn">Jason Ekstrand</span></a>
</span></b>
<pre>(In reply to Iago Toral from <a href="show_bug.cgi?id=84566#c39">comment #39</a>)
<span class="quote">> From your explanations I think this is what we should do too. For example,
> when the source type is RGBA ubyte, we will do something like this:
>
> if (src_array_format.as_uint == RGBA8888_UBYTE.as_uint &&
> !_mesa_is_format_integer_color(dst_format) {
> // Call pack function here
> }
>
> instead of:
>
> if (src_array_format.as_uint == RGBA8888_UBYTE.as_uint) {
> assert(!_mesa_is_format_integer_color(dst_format));
> // Call pack function here
> }
>
> That way, if dst is an integer type we will fall back to
> _mesa_swizzle_and_convert (if both src and dst are array types) or, as last
> resort, to the src->rgba->dst conversion path.</span >
Yes, that seems perfectly reasonable.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>