<p dir="ltr">Ack</p>
<div class="gmail_quote">On Oct 28, 2014 7:24 PM, "Kenneth Graunke" <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br>
<br>
I'd like to rename some files in i965:<br>
<br>
- brw_gs.c -> brw_ff_gs.c<br>
- brw_gs.h -> brw_ff_gs.h<br>
- brw_gs_emit.c -> brw_ff_gs_emit.c<br>
- brw_vec4_gs.c -> brw_gs.c<br>
- brw_vec4_gs.h -> brw_gs.h<br>
<br>
The current "brw_gs" files are about emulating fixed-function functionality<br>
(VF primitive decomposition and SOL) via the geometry shader; actual<br>
programmable geometry shader code is handled by brw_vec4_gs.[ch].<br>
<br>
With the advent of SIMD8 geometry shaders, "vec4_gs" will be confusing. "gs"<br>
is nicer. Most of the legacy code uses the "ff_gs" name already - when Paul<br>
respun his GS series, he renamed everything, but didn't change the filenames.<br>
<br>
Objections? Acks?<br>
<br>
The "i965-reorg" branch of my tree (~kwg/mesa) has two patches to do the<br>
renames:<br>
<br>
i965: Rename brw_vec4_gs.[ch] to brw_gs.[ch].<br>
i965: Rename brw_gs{,_emit}.[ch] to brw_ff_gs{,_emit}.[ch].<br>
<br>
Since they're purely "git mv" and #include fixes, I figured mailing out the<br>
diff would be useless.<br>
<br>
--Ken<br>_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
<br></blockquote></div>