<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Offscreen rendering to pixmap EGLSurface is odd" href="https://bugs.freedesktop.org/show_bug.cgi?id=85869#c2">Comment # 2</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Offscreen rendering to pixmap EGLSurface is odd" href="https://bugs.freedesktop.org/show_bug.cgi?id=85869">bug 85869</a> from <a class="email" href="mailto:lemody@gmail.com" title="Tapani Pälli <lemody@gmail.com>"> Tapani Pälli</a> <pre>bisected to: ---- 8< ---- commit 8f55174fbdc27076f310c4dfb1f87072588b8b0b Author: Kristian Høgsberg <<a href="mailto:krh@bitplanet.net">krh@bitplanet.net</a>> Date: Fri Aug 15 23:19:52 2014 -0700 meta: Make MESA_META_DRAW_BUFFERS restore properly A meta begin/end pair with MESA_META_DRAW_BUFFERS will change visible GL state. We recreate the draw buffer enums from the buffer bitfield, which changes GL_BACK to GL_BACK_LEFT (and GL_FRONT to GL_FRONT_LEFT). This commit modifes the save/restore logic to instead copy the buffer enums from the gl_framebuffer and then set them on restore using _mesa_drawbuffers(). It's not clear how this breaks the benchmark in 82796, but fixing meta to not leak the state change fixes the regression. No piglit regressions. Reviewed-by: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>> Fixes: <a class="bz_bug_link bz_status_VERIFIED bz_closed" title="VERIFIED FIXED - [IVB/BYT-M/HSW/BDW Bisected]Synmark2_v6.0_OglTerrainFlyInst/OglTerrainPanInst cannot run as image validation failed" href="show_bug.cgi?id=82796">https://bugs.freedesktop.org/show_bug.cgi?id=82796</a> Signed-off-by: Kristian Høgsberg <<a href="mailto:krh@bitplanet.net">krh@bitplanet.net</a>> Cc: <a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.org</a></pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>