<div dir="ltr">Hi,<div class="gmail_extra"><br><div class="gmail_quote">On 12 November 2014 12:37, <span dir="ltr"><<a href="mailto:jfonseca@vmware.com" target="_blank">jfonseca@vmware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">@@ -544,9 +544,22 @@ dri2_convert_glx_attribs(unsigned num_attribs, const uint32_t *attribs,<br>
case GLX_CONTEXT_COMPATIBILITY_PROFILE_BIT_ARB:<br>
*api = __DRI_API_OPENGL;<br>
break;<br>
- case GLX_CONTEXT_ES2_PROFILE_BIT_EXT:<br>
- *api = __DRI_API_GLES2;<br>
- break;<br>
+ case GLX_CONTEXT_ES_PROFILE_BIT_EXT:<br>
+ switch (*major_ver) {<br>
+ case 3:<br>
+ *api = __DRI_API_GLES3;<br>
+ break;<br>
+ case 2:<br>
+ *api = __DRI_API_GLES2;<br>
+ break;<br>
+ case 1:<br>
+ *api = __DRI_API_GLES;<br>
+ break;<br>
+ default:<br>
+ *error = __DRI_CTX_ERROR_BAD_API;<br>
+ return false;<br>
+ }<br>
+ break;<br>
default:<br>
*error = __DRI_CTX_ERROR_BAD_API;<br>
return false;<br>
@@ -577,19 +590,6 @@ dri2_convert_glx_attribs(unsigned num_attribs, const uint32_t *attribs,<br>
return false;<br>
}<br>
<br>
- /* The GLX_EXT_create_context_es2_profile spec says:<br>
- *<br>
- * "... If the version requested is 2.0, and the<br>
- * GLX_CONTEXT_ES2_PROFILE_BIT_EXT bit is set in the<br>
- * GLX_CONTEXT_PROFILE_MASK_ARB attribute (see below), then the context<br>
- * returned will implement OpenGL ES 2.0. This is the only way in which<br>
- * an implementation may request an OpenGL ES 2.0 context."<br>
- */<br>
- if (*api == __DRI_API_GLES2 && (*major_ver != 2 || *minor_ver != 0)) {<br></blockquote><div><br></div><div>It looks like you're missing minor_ver checking here? For instance, 2.99 isn't a valid GLES version.</div><div><br></div><div>Cheers,</div><div>Daniel </div></div></div></div>