<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 18, 2014 at 12:44 AM, Iago Toral Quiroga <span dir="ltr"><<a href="mailto:itoral@igalia.com" target="_blank">itoral@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Samuel Iglesias Gonsalvez <<a href="mailto:siglesias@igalia.com">siglesias@igalia.com</a>><br>
<br>
Signed-off-by: Samuel Iglesias Gonsalvez <<a href="mailto:siglesias@igalia.com">siglesias@igalia.com</a>><br>
---<br>
src/mesa/main/format_pack.c.mako | 10 +++++++++-<br>
1 file changed, 9 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/src/mesa/main/format_pack.c.mako b/src/mesa/main/format_pack.c.mako<br>
index b9f4656..97adf6e 100644<br>
--- a/src/mesa/main/format_pack.c.mako<br>
+++ b/src/mesa/main/format_pack.c.mako<br>
@@ -84,7 +84,15 @@ pack_ubyte_${f.short_name()}(const GLubyte src[4], void *dst)<br>
%endif<br>
<br>
${channel_datatype(c)} ${<a href="http://c.name" target="_blank">c.name</a>} =<br>
- %if c.type == parser.UNSIGNED:<br>
+ %if not f.is_normalized():<br>
+ %if c.type == parser.FLOAT and c.size == 32:<br>
+ UBYTE_TO_FLOAT(src[${i}]);<br>
+ %elif c.type == parser.FLOAT and c.size == 16:<br>
+ _mesa_float_to_half(UBYTE_TO_FLOAT(src[${i}]));<br></blockquote><div><br></div><div>Same question here as in the previous patch. Why are we using UBYTE_TO_FLOAT?<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+ %else:<br>
+ (${channel_datatype(c)}) src[${i}];<br>
+ %endif<br>
+ %elif c.type == parser.UNSIGNED:<br>
%if f.colorspace == 'srgb' and <a href="http://c.name" target="_blank">c.name</a> in 'rgb':<br>
util_format_linear_to_srgb_8unorm(src[${i}]);<br>
%else:<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.9.1<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>