<div dir="ltr"> <div class="gmail_extra"> <div class="gmail_quote">On Wed, Nov 19, 2014 at 11:24 PM, Iago Toral <<a href="mailto:itoral@igalia.com" target="_blank">itoral@igalia.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Jason, we discussed this some weeks ago actually, the detailed explanation is here: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=84566#c5" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=84566#c5</a> the short answer is that this is necessary because there is a normalized parameter to _mesa_swizzle_and_convert, and when we deal with float types we want to set this to true. </blockquote><div> </div><div>I went back and looked at that and I thought the result of the discussion was to fix the assert in mesa_format_convert and compute the normalized parameter correctly. After that, I thought this shouldn't be strictly needed. It may still be a good idea for consistency, but I want to make sure we're doing the right thing in mesa_format_convert </div><div>--Jason </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Iago <div class="HOEnZb"><div class="h5"> On Wed, 2014-11-19 at 11:31 -0800, Jason Ekstrand wrote: > I'm not sure what I think about this. Does it make a functional > change other than consistancy? > > --Jason > > > On Tue, Nov 18, 2014 at 1:23 AM, Iago Toral Quiroga > <<a href="mailto:itoral@igalia.com">itoral@igalia.com</a>> wrote: > In order to check if a format is normalized Mesa does > something like this: > normalized = !_mesa_is_enum_format_integer(srcFormat); > > So all float types will set normalized to true. Since our > mesa_array_format > includes a normalized flag for each type we want to make it > consistent with > this. > --- > src/mesa/main/format_info.py | 3 ++- > src/mesa/main/format_utils.c | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/main/format_info.py > b/src/mesa/main/format_info.py > index 315767d..d4bc276 100644 > --- a/src/mesa/main/format_info.py > +++ b/src/mesa/main/format_info.py > @@ -220,9 +220,10 @@ for fmat in formats: > print ' {{ {0} }},'.format(', '.join(map(str, > fmat.swizzle))) > if fmat.is_array() and fmat.colorspace in ('rgb', 'srgb'): > chan = fmat.array_element() > + norm = chan.norm or chan.type == parser.FLOAT > print ' {{{{ {0} }}}},'.format(', '.join([ > get_array_format_datatype(chan), > - str(int(chan.norm)), > + str(int(norm)), > str(len(fmat.channels)), > str(fmat.swizzle[0]), > str(fmat.swizzle[1]), > diff --git a/src/mesa/main/format_utils.c > b/src/mesa/main/format_utils.c > index c3815cb..1d65f2b 100644 > --- a/src/mesa/main/format_utils.c > +++ b/src/mesa/main/format_utils.c > @@ -30,7 +30,7 @@ > > mesa_array_format RGBA8888_FLOAT = {{ > MESA_ARRAY_FORMAT_TYPE_FLOAT, > - 0, > + 1, > 4, > 0, 1, 2, 3, > 0, 1 > -- > 1.9.1 > > _______________________________________________ > mesa-dev mailing list > <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> > <a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> > > </div></div></blockquote></div> </div></div>