<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_REOPENED " title="REOPENED - Incorrect/undefined behavior from shifting an integer too far" href="https://bugs.freedesktop.org/show_bug.cgi?id=87136#c3">Comment # 3</a> on <a class="bz_bug_link bz_status_REOPENED " title="REOPENED - Incorrect/undefined behavior from shifting an integer too far" href="https://bugs.freedesktop.org/show_bug.cgi?id=87136">bug 87136</a> from <a class="email" href="mailto:brucedawson@cygnus-software.com" title="Bruce Dawson <brucedawson@cygnus-software.com>"> Bruce Dawson</a> <pre>(In reply to Brian Paul from <a href="show_bug.cgi?id=87136#c2">comment #2</a>) > Created <a href="attachment.cgi?id=110683" name="attach_110683" title="patch to fix the issues in s_span.c">attachment 110683</a> <a href="attachment.cgi?id=110683&action=edit" title="patch to fix the issues in s_span.c">[details]</a> <a href='page.cgi?id=splinter.html&bug=87136&attachment=110683'>[review]</a> [review] > patch to fix the issues in s_span.c > > Hi Bruce! Long time no see (err, email). > > Here's a patch which I believe will fix the issues in s_span.c. I think > I've actually seen warnings about that in the past. But the swrast code is > pretty old and not used much anymore so it hasn't been a high priority. > > Can you apply the patch and see if that resolves the warnings you saw? > > Thanks. Hi Brian -- last seen in Hawaii I believe? Small world. Our version of mesa seems to be extremely old, predating the rename from FRAG_ATTRIB_MAX to VARYING_SLOT_MAX, so I can't apply the patch, but I took a look at it. I don't understand the first fix where you change the loop range to SPAN_NUM_ATTRIBS. That seems orthogonal. It seems that the (1 << i) still needs updating. The second fix looks good.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>