<div dir="ltr"><div>Fine by me<br><br></div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com">jason.ekstrand@intel.com</a>><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 30, 2014 at 12:23 PM, Kenneth Graunke <span dir="ltr"><<a href="mailto:kenneth@whitecape.org" target="_blank">kenneth@whitecape.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This makes it show up via ARB_debug_output and is also less code.<br>
<br>
Signed-off-by: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>><br>
---<br>
 src/mesa/drivers/dri/i965/brw_draw.c | 13 ++++---------<br>
 1 file changed, 4 insertions(+), 9 deletions(-)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c<br>
index c581cc0..5cd3f01 100644<br>
--- a/src/mesa/drivers/dri/i965/brw_draw.c<br>
+++ b/src/mesa/drivers/dri/i965/brw_draw.c<br>
@@ -520,15 +520,10 @@ retry:<br>
            fail_next = true;<br>
            goto retry;<br>
         } else {<br>
-           if (intel_batchbuffer_flush(brw) == -ENOSPC) {<br>
-              static bool warned = false;<br>
-<br>
-              if (!warned) {<br>
-                 fprintf(stderr, "i965: Single primitive emit exceeded"<br>
-                         "available aperture space\n");<br>
-                 warned = true;<br>
-              }<br>
-           }<br>
+            int ret = intel_batchbuffer_flush(brw);<br>
+            WARN_ONCE(ret == -ENOSPC,<br>
+                      "i965: Single primitive emit exceeded "<br>
+                      "available aperture space\n");<br>
         }<br>
       }<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
2.2.1<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>