<html>
    <head>
      <base href="https://bugs.freedesktop.org/" />
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - dEQP-GLES3.functional.fbo.completeness.renderable.renderbuffer.color0 tests fail due to enabling of GL_RGB and GL_RGBA"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=88079">88079</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>dEQP-GLES3.functional.fbo.completeness.renderable.renderbuffer.color0 tests fail due to enabling of GL_RGB and GL_RGBA
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>Mesa
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>git
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>All
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>Linux (All)
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>medium
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>Mesa core
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>mesa-dev@lists.freedesktop.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>michael.w.mason@intel.com
          </td>
        </tr></table>
      <p>
        <div>
        <pre>Environment:
Mesa: (master 934e41c0b31cffa4efc08f61cff2389e3149b3f3)
Ubuntu 14.04


The following dEQP tests fail due to a recent commit that enables GL_RGB and
GL_RGBA internal formats for render buffers:

dEQP-GLES3.functional.fbo.completeness.renderable.renderbuffer.color0.rgb_unsigned_byte
dEQP-GLES3.functional.fbo.completeness.renderable.renderbuffer.color0.rgb_unsigned_short_5_6_5
dEQP-GLES3.functional.fbo.completeness.renderable.renderbuffer.color0.rgb_unsigned_int_2_10_10_10_rev
dEQP-GLES3.functional.fbo.completeness.renderable.renderbuffer.color0.rgb_unsigned_int_10f_11f_11f_rev
dEQP-GLES3.functional.fbo.completeness.renderable.renderbuffer.color0.rgba_unsigned_byte
dEQP-GLES3.functional.fbo.completeness.renderable.renderbuffer.color0.rgba_unsigned_short_4_4_4_4
dEQP-GLES3.functional.fbo.completeness.renderable.renderbuffer.color0.rgba_unsigned_short_5_5_5_1
dEQP-GLES3.functional.fbo.completeness.renderable.renderbuffer.color0.rgba_unsigned_int_2_10_10_10_rev


Output:

# ./deqp-gles3
--deqp-case=dEQP-GLES3.functional.fbo.completeness.renderable.renderbuffer.color0.rgb_unsigned_byte
dEQP Core 2014.x (0xcafebabe) starting..
  target implementation = 'X11 EGL'

Test case
'dEQP-GLES3.functional.fbo.completeness.renderable.renderbuffer.color0.rgb_unsigned_byte'..
  Fail (Framebuffer checked as complete, expected incomplete)
Test case duration in microseconds = 2719 us

DONE!

Test run totals:
  Passed:        0/1 (0.0%)
  Failed:        1/1 (100.0%)
  Not supported: 0/1 (0.0%)
  Warnings:      0/1 (0.0%)

All the above mentioned tests fail in the same way.


Analysis:

Bisect shows 78942787170615c9333810cf3a4819a13c9eb8e8 is the first bad commit

commit 78942787170615c9333810cf3a4819a13c9eb8e8
Author:     Eduardo Lima Mitev <<a href="mailto:elima@igalia.com">elima@igalia.com</a>>
AuthorDate: Thu Nov 20 14:02:46 2014 +0100
Commit:     Iago Toral Quiroga <<a href="mailto:itoral@igalia.com">itoral@igalia.com</a>>
CommitDate: Tue Dec 9 11:40:00 2014 +0100

    mesa: Enables GL_RGB and GL_RGBA unsized internal formats for OpenGL ES 3.0

    GL_RGB and GL_RGBA are valid internal formats on a GLES3 profile. See
    "Table 1. Unsized Internal Formats" at
    <a href="https://www.khronos.org/opengles/sdk/docs/man3/html/glTexImage2D.xhtml">https://www.khronos.org/opengles/sdk/docs/man3/html/glTexImage2D.xhtml</a>.

    Fixes 2 dEQP tests:
    - dEQP-GLES3.functional.state_query.internal_format.rgb_samples
    - dEQP-GLES3.functional.state_query.internal_format.rgba_samples

    Reviewed-by: Brian Paul <<a href="mailto:brianp@vmware.com">brianp@vmware.com</a>>

This commit fixes tests where glGetInternalformativ() is used to get the number
of samples supported by a particular internal format for a render buffer.  Pg
242 of the GLES 3.0.4 spec implies that GL_RGB and GL_RGBA are valid inputs to
glGetInternalformativ().  However, these are unsized internal formats and are
not supported for render buffers according to pg 204 of the spec, which states
a renderbuffer's internal format "must be a sized internal format...".

The commit updates _mesa_base_fbo_format() to allow GL_RGB and GL_RGBA as valid
render buffer internal formats.  It has the effect of enabling those formats
for glGetInternalformativ() and
glRenderBufferStorage()/glRenderBufferStorageMultisample().  It should have
only enabled the formats for glGetInternalformativ().


Steps to reproduce:

# ./deqp-gles3
--deqp-case=dEQP-GLES3.functional.fbo.completeness.renderable.renderbuffer.color0.rgb_unsigned_byte</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>