<div dir="ltr"><div>FYI: I just pushed the NIR patches with Connor's R-B so as soon as we're done with <a href="http://configure.ac">configure.ac</a>, we should be building on RHEL6 again. </div>--Jason </div><div class="gmail_extra"> <div class="gmail_quote">On Wed, Jan 21, 2015 at 5:37 PM, Ian Romanick <<a href="mailto:idr@freedesktop.org" target="_blank">idr@freedesktop.org</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On 01/21/2015 05:35 PM, Matt Turner wrote: > On Wed, Jan 21, 2015 at 5:28 PM, Dave Airlie <<a href="mailto:airlied@gmail.com">airlied@gmail.com</a>> wrote: >> From: Dave Airlie <<a href="mailto:airlied@redhat.com">airlied@redhat.com</a>> >> >> anonymous structs/union don't work with c99 but do work with gnu99 >> on gcc 4.4. >> >> This on top of Jason's designated initialisers changes, make >> Mesa build on RHEL6 again. >> >> Signed-off-by: Dave Airlie <<a href="mailto:airlied@redhat.com">airlied@redhat.com</a>> >> --- >> <a href="http://configure.ac" target="_blank">configure.ac</a> | 12 +++++++++++- >> 1 files changed, 11 insertions(+), 1 deletions(-) >> >> diff --git a/<a href="http://configure.ac" target="_blank">configure.ac</a> b/<a href="http://configure.ac" target="_blank">configure.ac</a> >> index a4c5c74..9420a90 100644 >> --- a/<a href="http://configure.ac" target="_blank">configure.ac</a> >> +++ b/<a href="http://configure.ac" target="_blank">configure.ac</a> >> @@ -145,6 +145,7 @@ AC_MSG_RESULT([$acv_mesa_CLANG]) >> dnl If we're using GCC, make sure that it is at least version 4.2.0. Older >> dnl versions are explictly not supported. >> GEN_ASM_OFFSETS=no >> +USE_GNU99=no >> if test "x$GCC" = xyes -a "x$acv_mesa_CLANG" = xno; then >> AC_MSG_CHECKING([whether gcc version is sufficient]) >> major=0 >> @@ -163,6 +164,9 @@ if test "x$GCC" = xyes -a "x$acv_mesa_CLANG" = xno; then >> AC_MSG_RESULT([yes]) >> fi >> >> + if test $GCC_VERSION_MAJOR -lt 4 -o $GCC_VERSION_MAJOR -eq 4 -a $GCC_VERSION_MINOR -lt 6 ; then > > Can't we just do this test... > >> + USE_GNU99=yes >> + fi >> if test "x$cross_compiling" = xyes; then >> GEN_ASM_OFFSETS=yes >> fi >> @@ -221,7 +225,13 @@ esac >> >> dnl Add flags for gcc and g++ >> if test "x$GCC" = xyes; then >> - CFLAGS="$CFLAGS -Wall -std=c99" >> + CFLAGS="$CFLAGS -Wall" >> + >> + if test "x$USE_GNU99" = xyes; then > > ... right here? </div></div>It would happen on clang if we did. Above, it's inside a block of "am I GCC and definitely not clang". That said, I don't know how important that is... <div class="HOEnZb"><div class="h5"> >> + CFLAGS="$CFLAGS -std=gnu99" >> + else >> + CFLAGS="$CFLAGS -std=c99" >> + fi >> >> # Enable -Werror=implicit-function-declaration and >> # -Werror=missing-prototypes, if available, or otherwise, just >> -- >> 1.7.1 >> >> _______________________________________________ >> mesa-dev mailing list >> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> >> <a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> > _______________________________________________ > mesa-dev mailing list > <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> > <a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> > _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </div></div></blockquote></div> </div>