<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:vlee@freedesktop.org" title="Vinson Lee <vlee@freedesktop.org>"> <span class="fn">Vinson Lee</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - nir/nir_constant_expressions.c:2754:15: error: controlling expression type 'unsigned int' not compatible with any generic association type"
href="https://bugs.freedesktop.org/show_bug.cgi?id=88806">bug 88806</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Keywords</td>
<td>
</td>
<td>bisected
</td>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>cwabbott0@gmail.com, jason@jlekstrand.net
</td>
</tr>
<tr>
<td style="text-align:right;">Blocks</td>
<td>
</td>
<td>79706
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - nir/nir_constant_expressions.c:2754:15: error: controlling expression type 'unsigned int' not compatible with any generic association type"
href="https://bugs.freedesktop.org/show_bug.cgi?id=88806#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - nir/nir_constant_expressions.c:2754:15: error: controlling expression type 'unsigned int' not compatible with any generic association type"
href="https://bugs.freedesktop.org/show_bug.cgi?id=88806">bug 88806</a>
from <span class="vcard"><a class="email" href="mailto:vlee@freedesktop.org" title="Vinson Lee <vlee@freedesktop.org>"> <span class="fn">Vinson Lee</span></a>
</span></b>
<pre>89285e4d47a65e52547180dca46ecfd81b2996e9 is the first bad commit
commit 89285e4d47a65e52547180dca46ecfd81b2996e9
Author: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com">jason.ekstrand@intel.com</a>>
Date: Fri Jan 23 13:38:46 2015 -0800
nir: add new constant folding infrastructure
Add a required field to the Opcode class, const_expr, that contains an
expression or statement that computes the result of the opcode given known
constant inputs. Then take those const_expr's and expand them into a
function
that takes an opcode and an array of constant inputs and spits out the
constant
result. This means that when adding opcodes, there's one less place to
update,
and almost all the opcodes are self-documenting since the information on
how to
compute the result is right next to the definition.
The helper functions in nir_constant_expressions.c were taken from
ir_constant_expressions.cpp.
v3 Jason Ekstrand <<a href="mailto:jason.ekstrand@iastate.edu">jason.ekstrand@iastate.edu</a>>
- Use mako to generate one function per opcode instead of doing piles of
string splicing
v4 Jason Ekstrand <<a href="mailto:jason.ekstrand@iastate.edu">jason.ekstrand@iastate.edu</a>>
- More comments and better indentation in the mako
- Add a description of the constant expression language in nir_opcodes.py
- Added nir_constant_expressions.py to EXTRA_DIST in Makefile.am
Signed-off-by: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com">jason.ekstrand@intel.com</a>>
Reviewed-by: Connor Abbott <<a href="mailto:cwabbott0@gmail.com">cwabbott0@gmail.com</a>>
:040000 040000 4823f33d8c6840f25c1aefc6c61cec212492c805
5d152f618ce5fe346a0e71f4be242b597120a219 M src
bisect run success</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>