<div dir="ltr"> <div class="gmail_extra"> <div class="gmail_quote">On Mon, Jan 26, 2015 at 3:58 PM, Eric Anholt <<a href="mailto:eric@anholt.net" target="_blank">eric@anholt.net</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> writes: > On Mon, Jan 26, 2015 at 11:21 AM, Eric Anholt <<a href="mailto:eric@anholt.net">eric@anholt.net</a>> wrote: > >> Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> writes: >> > + case nir_instr_type_phi: { >> > + nir_phi_instr *src_phi = nir_instr_as_phi(src_instr); >> > + >> > + /* Insert an entry and mark it as scalarizable for now. That >> way >> > + * we don't recurse forever and a cycle in the depencence graph >> > + * won't automatically make us fail to scalarize. >> > + */ >> > + entry = _mesa_hash_table_insert(state->phi_table, src_phi, >> (void *)1); >> >> I expect "(void *)1" will give compiler warnings generally. "(void >> *)(uintptr_t)1" is the usual workaround. >> >> Useful comment, though! >> >> > + bool scalarizable = should_lower_phi(src_phi, state); >> > + entry->data = (void *)scalarizable; >> >> No need to cast to void *, since not C++. >> > > I'm confused. You want more casting above but less here? Could you pleas > be a little more specific. Yes, you have to add the cast above to avoid a compiler warning about casting from a small int to a pointer, while casting to void * to assign to a void * is only a c++ism </blockquote></div> </div><div class="gmail_extra">But I'm casting a bool to void *... </div></div>