<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 02/02/15 23:51, Laura Ekstrand
wrote:<br>
</div>
<blockquote
cite="mid:CACH8GMPZmbP1dJC2mhQ2wFwv+QGPD3C5onTf=pGHVPokv7mCbA@mail.gmail.com"
type="cite">
<div dir="ltr"><br>
<div class="gmail_extra">
<div class="gmail_quote">On Mon, Feb 2, 2015 at 3:30 AM,
Martin Peres <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:martin.peres@linux.intel.com"
target="_blank">martin.peres@linux.intel.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div class="h5">
if (index >=
ctx->Const.MaxTransformFeedbackBuffers) {<br>
- _mesa_error(ctx, GL_INVALID_VALUE,
"glBindBufferRange(index=%d "<br>
- "out of bounds)", index);<br>
+ /* An INVALID_VALUE error is generated if index
is greater than or equal<br>
+ * to the number of binding points for
transform feedback, as described<br>
+ * in section 6.7.1.<br>
</div>
</div>
</blockquote>
<div>Include the spec ^^^^ (I presume OpenGL 4.5
core). <br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
Done, thanks<br>
<br>
<blockquote
cite="mid:CACH8GMPZmbP1dJC2mhQ2wFwv+QGPD3C5onTf=pGHVPokv7mCbA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div class="h5">
+ */<br>
+ _mesa_error(ctx, GL_INVALID_VALUE, "%s(index=%d
out of bounds)",<br>
+ gl_methd_name, index);<br>
return;<br>
}<br>
<br>
if (size & 0x3) {<br>
- /* must a multiple of four */<br>
- _mesa_error(ctx, GL_INVALID_VALUE,
"glBindBufferRange(size=%d)",<br>
- (int) size);<br>
+ /* must a be multiple of four */<br>
+ _mesa_error(ctx, GL_INVALID_VALUE, "%s(size=%d
must be a multiple of "<br>
+ "four)", gl_methd_name, (int)
size);<br>
return;<br>
}<br>
<br>
if (offset & 0x3) {<br>
/* must be multiple of four */<br>
- _mesa_error(ctx, GL_INVALID_VALUE,<br>
- "glBindBufferRange(offset=%d)",
(int) offset);<br>
+ _mesa_error(ctx, GL_INVALID_VALUE,
"gl%s(offset=%d must be a multiple "<br>
+ "of four)", gl_methd_name, (int)
offset);<br>
return;<br>
- }<br>
+ }<br>
+<br>
</div>
</div>
+ if (offset < 0) {<br>
+ /* An INVALID_VALUE error is generated by
BindBufferRange if buffer is<br>
<span class="">+ * non-zero and size is less than or
equal to zero.<br>
</span></blockquote>
<div>They're still mixed up. ^^ It says size instead of
offset.<br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
I'm so sorry! I fixed it properly now!<br>
</body>
</html>