<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
On 02/02/15 23:36, Laura Ekstrand wrote:<br>
<blockquote
cite="mid:CACH8GMNZMQqGY9MxyqLOfrV59SHKhT9h8Hbq27Av324_QBCaTw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">On Mon, Feb 2, 2015 at 2:58 AM, Martin
Peres <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:martin.peres@linux.intel.com" target="_blank">martin.peres@linux.intel.com</a>></span>
wrote:<br>
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><span
class=""> if (!obj) {<br>
- _mesa_error(ctx, GL_OUT_OF_MEMORY,
"glGenTransformFeedbacks");<br>
</span>+ _mesa_error(ctx, GL_OUT_OF_MEMORY,
"%s", func);</blockquote>
<div> ^^<br>
</div>
<div>This doesn't line up with ( above. Mesa uses 3-space
identation. <br>
</div>
</div>
</div>
</div>
</blockquote>
Seems like a visualisation problem as the indentation was good
before the patch and is still good after it...<br>
<blockquote
cite="mid:CACH8GMNZMQqGY9MxyqLOfrV59SHKhT9h8Hbq27Av324_QBCaTw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class=""> return;<br>
}<br>
- names[i] = first + i;<br>
+ ids[i] = first + i;<br>
</span></blockquote>
<div>Same thing <br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
Same thing <br>
<blockquote
cite="mid:CACH8GMNZMQqGY9MxyqLOfrV59SHKhT9h8Hbq27Av324_QBCaTw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><span
class="">
_mesa_HashInsert(ctx->TransformFeedback.Objects,
first + i, obj);<br>
</span>+ if (dsa) {<br>
+ /* this is normally done at bind time in the
non-dsa case */<br>
+ obj->EverBound = GL_TRUE;<br>
+ }<br>
<span class=""> }<br>
}<br>
else {<br>
- _mesa_error(ctx, GL_OUT_OF_MEMORY,
"glGenTransformFeedbacks");<br>
</span>+ _mesa_error(ctx, GL_OUT_OF_MEMORY, "%s",
func);<br>
</blockquote>
<div>Same thing. <br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
Same thing. <br>
</body>
</html>