<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [PNV Bisected]Ogles2conform ES2-CTS.gtf.GL2ExtensionTests.texture_float.texture_float segfault"
href="https://bugs.freedesktop.org/show_bug.cgi?id=88907#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [PNV Bisected]Ogles2conform ES2-CTS.gtf.GL2ExtensionTests.texture_float.texture_float segfault"
href="https://bugs.freedesktop.org/show_bug.cgi?id=88907">bug 88907</a>
from <span class="vcard"><a class="email" href="mailto:idr@freedesktop.org" title="Ian Romanick <idr@freedesktop.org>"> <span class="fn">Ian Romanick</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=113390" name="attach_113390" title="patch to fix the issue">attachment 113390</a> <a href="attachment.cgi?id=113390&action=edit" title="patch to fix the issue">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=88907&attachment=113390'>[review]</a>
patch to fix the issue
Review of <span class=""><a href="attachment.cgi?id=113390" name="attach_113390" title="patch to fix the issue">attachment 113390</a> <a href="attachment.cgi?id=113390&action=edit" title="patch to fix the issue">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=88907&attachment=113390'>[review]</a>:
-----------------------------------------------------------------
I think the problem is that adjust_for_oes_float_texture is called even when
internalFormat is not GL_FLOAT, GL_HALF_FLOAT_OES, or GL_HALF_FLOAT.
It seems like this would be better:
if (_mesa_is_gles(ctx) && format == internalFormat) {
if (type == GL_FLOAT) {
texObj->_IsFloat = GL_TRUE;
internalFormat = adjust_for_oes_float_texture(format, type);
} else if (type == GL_HALF_FLOAT_OES || type == GL_HALF_FLOAT) {
texObj->_IsHalfFloat = GL_TRUE;
internalFormat = adjust_for_oes_float_texture(format, type);
}
}</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>