<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [PNV Bisected]Ogles2conform ES2-CTS.gtf.GL2ExtensionTests.texture_float.texture_float segfault" href="https://bugs.freedesktop.org/show_bug.cgi?id=88907#c5">Comment # 5</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [PNV Bisected]Ogles2conform ES2-CTS.gtf.GL2ExtensionTests.texture_float.texture_float segfault" href="https://bugs.freedesktop.org/show_bug.cgi?id=88907">bug 88907</a> from <a class="email" href="mailto:lemody@gmail.com" title="Tapani Pälli <lemody@gmail.com>"> Tapani Pälli</a> <pre>(In reply to Ian Romanick from <a href="show_bug.cgi?id=88907#c3">comment #3</a>) > Comment on <a href="attachment.cgi?id=113390" name="attach_113390" title="patch to fix the issue">attachment 113390</a> <a href="attachment.cgi?id=113390&action=edit" title="patch to fix the issue">[details]</a> <a href='page.cgi?id=splinter.html&bug=88907&attachment=113390'>[review]</a> [review] > patch to fix the issue > > Review of <a href="attachment.cgi?id=113390" name="attach_113390" title="patch to fix the issue">attachment 113390</a> <a href="attachment.cgi?id=113390&action=edit" title="patch to fix the issue">[details]</a> <a href='page.cgi?id=splinter.html&bug=88907&attachment=113390'>[review]</a> [review]: > ----------------------------------------------------------------- > > I think the problem is that adjust_for_oes_float_texture is called even when > internalFormat is not GL_FLOAT, GL_HALF_FLOAT_OES, or GL_HALF_FLOAT. Nothing happens in the function if format was not one of these formats so not calling it does not seem to change existing functionality. I think extension check seems very relevant here because these things should happen only because of the extension is enabled, not because you are running ES2. i965 should be only driver currently supporting this extension on ES2.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>