<div dir="ltr">Yeah... More proof that the lower_load_payload code is plenty bogus...<br><br>Reviewed-by: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com" target="_blank">jason.ekstrand@intel.com</a>><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Feb 6, 2015 at 9:42 AM, Francisco Jerez <span dir="ltr"><<a href="mailto:currojerez@riseup.net" target="_blank">currojerez@riseup.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">---<br>
src/mesa/drivers/dri/i965/brw_fs.cpp | 8 ++++++++<br>
1 file changed, 8 insertions(+)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp<br>
index 8da1f47..e2ebf7e 100644<br>
--- a/src/mesa/drivers/dri/i965/brw_fs.cpp<br>
+++ b/src/mesa/drivers/dri/i965/brw_fs.cpp<br>
@@ -3116,6 +3116,14 @@ fs_visitor::lower_load_payload()<br>
inst->src[i].reg_offset;<br>
mov->force_sechalf = metadata[src_reg].force_sechalf;<br>
mov->force_writemask_all = metadata[src_reg].force_writemask_all;<br>
+ } else {<br>
+ /* We don't have any useful metadata for immediates or<br>
+ * uniforms. Assume that any of the channels of the<br>
+ * destination may be used.<br>
+ */<br>
+ assert(inst->src[i].file == IMM ||<br>
+ inst->src[i].file == UNIFORM);<br>
+ mov->force_writemask_all = true;<br>
}<br>
<br>
if (dst.file == GRF) {<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.1.3<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>