<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 23, 2015 at 12:51 AM, Martin Peres <span dir="ltr"><<a href="mailto:martin.peres@linux.intel.com" target="_blank">martin.peres@linux.intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 20/02/15 20:38, Laura Ekstrand wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Please provide a page number and a section title in your spec comment.<br>
</blockquote>
<br></span>
I'm not very fond of giving the page number as Khronos updates the pdf quite often<br>
and the page number may change. Since I see so little people write the pdf page<br>
number, is there a policy in place?<br>
<br>
Anyway, I updated the commit locally and I'll be updating all the other patches.<br></blockquote><div><br></div><div>People do tend to use page numbers from what I've seen. Yes, it has the potential to get out-of-sync but probably never by more than a page or two. I don't thnk spec updates are all that substantial, especially in older versions. You could also give a section number (down to the subsection) but that isn't quite as nice especially when the subsections are large. The big point is not to say "Here's a quote from *somewhere* in this 300 page PDF document. Go fish!" :-)<br></div><div>--Jason<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Thanks.<span class=""><br>
<br>
On Mon, Feb 16, 2015 at 6:13 AM, Martin Peres <<a href="mailto:martin.peres@linux.intel.com" target="_blank">martin.peres@linux.intel.com</a> <mailto:<a href="mailto:martin.peres@linux.intel.com" target="_blank">martin.peres@linux.<u></u>intel.com</a>>> wrote:<br>
<br>
Maybe this should be the job of the dispatch layer.<br>
<br>
Signed-off-by: Martin Peres <<a href="mailto:martin.peres@linux.intel.com" target="_blank">martin.peres@linux.intel.com</a><br></span>
<mailto:<a href="mailto:martin.peres@linux.intel.com" target="_blank">martin.peres@linux.<u></u>intel.com</a>>><div><div class="h5"><br>
---<br>
src/mesa/main/multisample.c | 9 +++++++++<br>
1 file changed, 9 insertions(+)<br>
<br>
diff --git a/src/mesa/main/multisample.c b/src/mesa/main/multisample.c<br>
index 1f3fa0c..a0a659b 100644<br>
--- a/src/mesa/main/multisample.c<br>
+++ b/src/mesa/main/multisample.c<br>
@@ -150,6 +150,15 @@ GLenum<br>
_mesa_check_sample_count(<u></u>struct gl_context *ctx, GLenum target,<br>
GLenum internalFormat, GLsizei samples)<br>
{<br>
+ /* From the OpenGL core 3.0 spec, section 2.5:<br>
+ *<br>
+ * "If a negative number is provided where an argument of type<br>
sizei or<br>
+ * sizeiptr is specified, the error INVALID VALUE is generated."<br>
+ */<br>
+ if (samples < 0) {<br>
+ return GL_INVALID_VALUE;<br>
+ }<br>
+<br>
/* If ARB_internalformat_query is supported, then treat its<br>
highest<br>
* returned sample count as the absolute maximum for this<br>
format; it is<br>
* allowed to exceed MAX_SAMPLES.<br>
--<br>
2.3.0<br>
<br>
______________________________<u></u>_________________<br>
mesa-dev mailing list<br></div></div>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a> <mailto:<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.<u></u>freedesktop.org</a>><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/<u></u>mailman/listinfo/mesa-dev</a><br>
<br>
<br>
</blockquote><div class="HOEnZb"><div class="h5">
<br>
______________________________<u></u>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/<u></u>mailman/listinfo/mesa-dev</a><br>
</div></div></blockquote></div><br></div></div>