<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 4, 2015 at 8:45 AM, Ian Romanick <span dir="ltr"><<a href="mailto:idr@freedesktop.org" target="_blank">idr@freedesktop.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 03/01/2015 05:19 PM, Jason Ekstrand wrote:<br>
> Not sure why you Cc'd me, but whatever.  Seems obvious enough.<br>
<br>
</span>Because b18fd23 was your commit.  Sometimes left over, unused parameters<br>
are the result of a mistake.  I just wanted to be sure.<br><div class="HOEnZb"><div class="h5"></div></div></blockquote><div><br></div><div>Right... Sorry, it's been a while and I forgot I touched those functions.  That said, it makes sense that b18fd23 would have.  Sorry for the noise<br></div><div>--Jason<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
> Reviewed-by: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com">jason.ekstrand@intel.com</a>><br>
> On 02/27/2015 06:50 PM, Ian Romanick wrote:<br>
>> From: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>><br>
>><br>
>> Unused since b18fd23.<br>
>><br>
>> brw_fs.cpp:2878:44: warning: unused parameter 'dispatch_width'<br>
>> [-Wunused-parameter]<br>
>>   clear_deps_for_inst_src(fs_inst *inst, int dispatch_width, bool *deps,<br>
>>                                              ^<br>
>><br>
>> Signed-off-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>><br>
>> Cc: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com">jason.ekstrand@intel.com</a>><br>
>> ---<br>
>>   src/mesa/drivers/dri/i965/brw_fs.cpp | 12 ++++--------<br>
>>   1 file changed, 4 insertions(+), 8 deletions(-)<br>
>><br>
>> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp<br>
>> b/src/mesa/drivers/dri/i965/brw_fs.cpp<br>
>> index 0354f56..126b7d0 100644<br>
>> --- a/src/mesa/drivers/dri/i965/brw_fs.cpp<br>
>> +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp<br>
>> @@ -2875,8 +2875,7 @@ fs_visitor::remove_duplicate_mrf_writes()<br>
>>   }<br>
>>     static void<br>
>> -clear_deps_for_inst_src(fs_inst *inst, int dispatch_width, bool *deps,<br>
>> -                        int first_grf, int grf_len)<br>
>> +clear_deps_for_inst_src(fs_inst *inst, bool *deps, int first_grf, int<br>
>> grf_len)<br>
>>   {<br>
>>      /* Clear the flag for registers that actually got read (as<br>
>> expected). */<br>
>>      for (int i = 0; i < inst->sources; i++) {<br>
>> @@ -2927,8 +2926,7 @@<br>
>> fs_visitor::insert_gen4_pre_send_dependency_workarounds(bblock_t *block,<br>
>>      memset(needs_dep, false, sizeof(needs_dep));<br>
>>      memset(needs_dep, true, write_len);<br>
>>   -   clear_deps_for_inst_src(inst, dispatch_width,<br>
>> -                           needs_dep, first_write_grf, write_len);<br>
>> +   clear_deps_for_inst_src(inst, needs_dep, first_write_grf, write_len);<br>
>>        /* Walk backwards looking for writes to registers we're writing<br>
>> which<br>
>>       * aren't read since being written.  If we hit the start of the<br>
>> program,<br>
>> @@ -2968,8 +2966,7 @@<br>
>> fs_visitor::insert_gen4_pre_send_dependency_workarounds(bblock_t *block,<br>
>>         }<br>
>>           /* Clear the flag for registers that actually got read (as<br>
>> expected). */<br>
>> -      clear_deps_for_inst_src(scan_inst, dispatch_width,<br>
>> -                              needs_dep, first_write_grf, write_len);<br>
>> +      clear_deps_for_inst_src(scan_inst, needs_dep, first_write_grf,<br>
>> write_len);<br>
>>           /* Continue the loop only if we haven't resolved all the<br>
>> dependencies */<br>
>>         int i;<br>
>> @@ -3014,8 +3011,7 @@<br>
>> fs_visitor::insert_gen4_post_send_dependency_workarounds(bblock_t<br>
>> *block, fs_ins<br>
>>         }<br>
>>           /* Clear the flag for registers that actually got read (as<br>
>> expected). */<br>
>> -      clear_deps_for_inst_src(scan_inst, dispatch_width,<br>
>> -                              needs_dep, first_write_grf, write_len);<br>
>> +      clear_deps_for_inst_src(scan_inst, needs_dep, first_write_grf,<br>
>> write_len);<br>
>>           /* We insert our reads as late as possible since they're<br>
>> reading the<br>
>>          * result of a SEND, which has massive latency.<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</div></div></blockquote></div><br></div></div>