LGTM. <div class="gmail_quote">On Mar 7, 2015 8:34 PM, "Sean Burke" <<a href="mailto:leftmostcat@gmail.com">leftmostcat@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The memory layout of compatible internal formats may differ in bytes per block, so TexFormat is not a reliable measure of compatibility. For example, GL_RGB8 and GL_RGB8UI are compatible formats, but GL_RGB8 may be laid out in memory as B8G8R8X8. If GL_RGB8UI has a 3 byte-per-block memory layout, the existing compatibility check will fail. Additionally, the current check allows any two compressed textures which share block size to be used, whereas the spec gives an explicit table of compatible formats. v2: Use a switch instead of array iteration for block class and show the Â Â correct GL error when internal formats are mismatched. v3: Include spec citations for new compatibility checks, rearrange check Â Â order to ensure that compressed, view-compatible formats return the Â Â correct result, and make style fixes. Original commit message amended Â Â for clarity. v4: Reformatted spec citations. Reviewed-by: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com">jason.ekstrand@intel.com</a>> --- Â src/mesa/main/copyimage.c | 151 +++++++++++++++++++++++++++++++++++++++------- Â 1 file changed, 130 insertions(+), 21 deletions(-) diff --git a/src/mesa/main/copyimage.c b/src/mesa/main/copyimage.c index 455929d..fd22f28 100644 --- a/src/mesa/main/copyimage.c +++ b/src/mesa/main/copyimage.c @@ -33,6 +33,12 @@ Â #include "texobj.h" Â #include "fbobject.h" Â #include "textureview.h" +#include "glformats.h" + +enum mesa_block_class { +Â Â BLOCK_CLASS_128_BITS, +Â Â BLOCK_CLASS_64_BITS +}; Â static bool Â prepare_target(struct gl_context *ctx, GLuint name, GLenum *target, int level, @@ -253,6 +259,124 @@ check_region_bounds(struct gl_context *ctx, struct gl_texture_image *tex_image, Â Â return true; Â } +static bool +compressed_format_compatible(struct gl_context *ctx, +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â GLenum compressedFormat, GLenum otherFormat) +{ +Â Â enum mesa_block_class compressedClass, otherClass; + +Â Â /* Two view-incompatible compressed formats are never compatible. */ +Â Â if (_mesa_is_compressed_format(ctx, otherFormat)) { +Â Â Â return false; +Â Â } + +Â Â /* +Â Â * From ARB_copy_image spec: +Â Â *Â Â Table 4.X.1 (Compatible internal formats for copying between +Â Â *Â Â Â Â Â Â Â Â Â compressed and uncompressed internal formats) +Â Â *Â Â --------------------------------------------------------------------- +Â Â *Â Â | Texel / | UncompressedÂ Â Â |Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â | +Â Â *Â Â | BlockÂ Â | internal formatÂ Â | Compressed internal formatÂ Â Â Â Â | +Â Â *Â Â | sizeÂ Â |Â Â Â Â Â Â Â Â Â Â |Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â | +Â Â *Â Â --------------------------------------------------------------------- +Â Â *Â Â | 128-bit | RGBA32UI,Â Â Â Â Â | COMPRESSED_RGBA_S3TC_DXT3_EXT,Â Â Â | +Â Â *Â Â |Â Â Â Â Â | RGBA32I,Â Â Â Â Â | COMPRESSED_SRGB_ALPHA_S3TC_DXT3_EXT,| +Â Â *Â Â |Â Â Â Â Â | RGBA32FÂ Â Â Â Â Â | COMPRESSED_RGBA_S3TC_DXT5_EXT,Â Â Â | +Â Â *Â Â |Â Â Â Â Â |Â Â Â Â Â Â Â Â Â Â | COMPRESSED_SRGB_ALPHA_S3TC_DXT5_EXT,| +Â Â *Â Â |Â Â Â Â Â |Â Â Â Â Â Â Â Â Â Â | COMPRESSED_RG_RGTC2,Â Â Â Â Â Â Â Â | +Â Â *Â Â |Â Â Â Â Â |Â Â Â Â Â Â Â Â Â Â | COMPRESSED_SIGNED_RG_RGTC2,Â Â Â Â Â | +Â Â *Â Â |Â Â Â Â Â |Â Â Â Â Â Â Â Â Â Â | COMPRESSED_RGBA_BPTC_UNORM,Â Â Â Â Â | +Â Â *Â Â |Â Â Â Â Â |Â Â Â Â Â Â Â Â Â Â | COMPRESSED_SRGB_ALPHA_BPTC_UNORM,Â Â | +Â Â *Â Â |Â Â Â Â Â |Â Â Â Â Â Â Â Â Â Â | COMPRESSED_RGB_BPTC_SIGNED_FLOAT,Â Â | +Â Â *Â Â |Â Â Â Â Â |Â Â Â Â Â Â Â Â Â Â | COMPRESSED_RGB_BPTC_UNSIGNED_FLOATÂ | +Â Â *Â Â --------------------------------------------------------------------- +Â Â *Â Â | 64-bitÂ | RGBA16F, RG32F,Â Â | COMPRESSED_RGB_S3TC_DXT1_EXT,Â Â Â Â | +Â Â *Â Â |Â Â Â Â Â | RGBA16UI, RG32UI, | COMPRESSED_SRGB_S3TC_DXT1_EXT,Â Â Â | +Â Â *Â Â |Â Â Â Â Â | RGBA16I, RG32I,Â Â | COMPRESSED_RGBA_S3TC_DXT1_EXT,Â Â Â | +Â Â *Â Â |Â Â Â Â Â | RGBA16,Â Â Â Â Â Â | COMPRESSED_SRGB_ALPHA_S3TC_DXT1_EXT,| +Â Â *Â Â |Â Â Â Â Â | RGBA16_SNORMÂ Â Â | COMPRESSED_RED_RGTC1,Â Â Â Â Â Â Â Â | +Â Â *Â Â |Â Â Â Â Â |Â Â Â Â Â Â Â Â Â Â | COMPRESSED_SIGNED_RED_RGTC1Â Â Â Â Â | +Â Â *Â Â --------------------------------------------------------------------- +Â Â */ + +Â Â switch (compressedFormat) { +Â Â Â case GL_COMPRESSED_RGBA_S3TC_DXT3_EXT: +Â Â Â case GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT3_EXT: +Â Â Â case GL_COMPRESSED_RGBA_S3TC_DXT5_EXT: +Â Â Â case GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT5_EXT: +Â Â Â case GL_COMPRESSED_RG_RGTC2: +Â Â Â case GL_COMPRESSED_SIGNED_RG_RGTC2: +Â Â Â case GL_COMPRESSED_RGBA_BPTC_UNORM: +Â Â Â case GL_COMPRESSED_SRGB_ALPHA_BPTC_UNORM: +Â Â Â case GL_COMPRESSED_RGB_BPTC_SIGNED_FLOAT: +Â Â Â case GL_COMPRESSED_RGB_BPTC_UNSIGNED_FLOAT: +Â Â Â Â Â compressedClass = BLOCK_CLASS_128_BITS; +Â Â Â Â Â break; +Â Â Â case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: +Â Â Â case GL_COMPRESSED_SRGB_S3TC_DXT1_EXT: +Â Â Â case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: +Â Â Â case GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT1_EXT: +Â Â Â case GL_COMPRESSED_RED_RGTC1: +Â Â Â case GL_COMPRESSED_SIGNED_RED_RGTC1: +Â Â Â Â Â compressedClass = BLOCK_CLASS_64_BITS; +Â Â Â Â Â break; +Â Â Â default: +Â Â Â Â Â return false; +Â Â } + +Â Â switch (otherFormat) { +Â Â Â case GL_RGBA32UI: +Â Â Â case GL_RGBA32I: +Â Â Â case GL_RGBA32F: +Â Â Â Â Â otherClass = BLOCK_CLASS_128_BITS; +Â Â Â Â Â break; +Â Â Â case GL_RGBA16F: +Â Â Â case GL_RG32F: +Â Â Â case GL_RGBA16UI: +Â Â Â case GL_RG32UI: +Â Â Â case GL_RGBA16I: +Â Â Â case GL_RG32I: +Â Â Â case GL_RGBA16: +Â Â Â case GL_RGBA16_SNORM: +Â Â Â Â Â otherClass = BLOCK_CLASS_64_BITS; +Â Â Â Â Â break; +Â Â Â default: +Â Â Â Â Â return false; +Â Â } + +Â Â return compressedClass == otherClass; +} + +static bool +copy_format_compatible(struct gl_context *ctx, +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â GLenum srcFormat, GLenum dstFormat) +{ +Â Â /* +Â Â * From ARB_copy_image spec: +Â Â *Â Â For the purposes of CopyImageSubData, two internal formats +Â Â *Â Â are considered compatible if any of the following conditions are +Â Â *Â Â met: +Â Â *Â Â * the formats are the same, +Â Â *Â Â * the formats are considered compatible according to the +Â Â *Â Â Â compatibility rules used for texture views as defined in +Â Â *Â Â Â section 3.9.X. In particular, if both internal formats are listed +Â Â *Â Â Â in the same entry of Table 3.X.2, they are considered compatible, or +Â Â *Â Â * one format is compressed and the other is uncompressed and +Â Â *Â Â Â Table 4.X.1 lists the two formats in the same row. +Â Â */ + +Â Â if (_mesa_texture_view_compatible_format(ctx, srcFormat, dstFormat)) { +Â Â Â /* Also checks if formats are equal. */ +Â Â Â return true; +Â Â } else if (_mesa_is_compressed_format(ctx, srcFormat)) { +Â Â Â return compressed_format_compatible(ctx, srcFormat, dstFormat); +Â Â } else if (_mesa_is_compressed_format(ctx, dstFormat)) { +Â Â Â return compressed_format_compatible(ctx, dstFormat, srcFormat); +Â Â } + +Â Â return false; +} + Â void GLAPIENTRY Â _mesa_CopyImageSubData(GLuint srcName, GLenum srcTarget, GLint srcLevel, Â Â Â Â Â Â Â Â Â Â Â Â GLint srcX, GLint srcY, GLint srcZ, @@ -265,7 +389,7 @@ _mesa_CopyImageSubData(GLuint srcName, GLenum srcTarget, GLint srcLevel, Â Â struct gl_texture_object *srcTexObj, *dstTexObj; Â Â struct gl_texture_image *srcTexImage, *dstTexImage; Â Â GLuint src_bw, src_bh, dst_bw, dst_bh; -Â Â int i, srcNewZ, dstNewZ, Bpt; +Â Â int i, srcNewZ, dstNewZ; Â Â if (MESA_VERBOSE & VERBOSE_API) Â Â Â Â _mesa_debug(ctx, "glCopyImageSubData(%u, %s, %d, %d, %d, %d, " @@ -306,15 +430,6 @@ _mesa_CopyImageSubData(GLuint srcName, GLenum srcTarget, GLint srcLevel, Â Â Â Â goto cleanup; Â Â } -Â Â /* Very simple sanity check.Â This is sufficient if one of the textures -Â Â * is compressed. */ -Â Â Bpt = _mesa_get_format_bytes(srcTexImage->TexFormat); -Â Â if (_mesa_get_format_bytes(dstTexImage->TexFormat) != Bpt) { -Â Â Â _mesa_error(ctx, GL_INVALID_VALUE, -Â Â Â Â Â Â Â Â Â "glCopyImageSubData(internalFormat mismatch)"); -Â Â Â goto cleanup; -Â Â } - Â Â if (!check_region_bounds(ctx, srcTexImage, srcX, srcY, srcZ, Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â srcWidth, srcHeight, srcDepth, "src")) Â Â Â Â goto cleanup; @@ -324,17 +439,11 @@ _mesa_CopyImageSubData(GLuint srcName, GLenum srcTarget, GLint srcLevel, Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â (srcHeight / src_bh) * dst_bh, srcDepth, "dst")) Â Â Â Â goto cleanup; -Â Â if (_mesa_is_format_compressed(srcTexImage->TexFormat)) { -Â Â Â /* XXX: Technically, we should probaby do some more specific checking -Â Â Â Â * here.Â However, this should be sufficient for all compressed -Â Â Â Â * formats that mesa supports since it is a direct memory copy. -Â Â Â Â */ -Â Â } else if (_mesa_is_format_compressed(dstTexImage->TexFormat)) { -Â Â } else if (_mesa_texture_view_compatible_format(ctx, -Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â srcTexImage->InternalFormat, - dstTexImage->InternalFormat)) { -Â Â } else { -Â Â Â return; /* Error logged by _mesa_texture_view_compatible_format */ +Â Â if (!copy_format_compatible(ctx, srcTexImage->InternalFormat, +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â dstTexImage->InternalFormat)) { +Â Â Â _mesa_error(ctx, GL_INVALID_OPERATION, +Â Â Â Â Â Â Â Â Â "glCopyImageSubData(internalFormat mismatch)"); +Â Â Â goto cleanup; Â Â } Â Â for (i = 0; i < srcDepth; ++i) { -- 2.1.0 </blockquote></div>