<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:jfonseca@vmware.com" title="José Fonseca <jfonseca@vmware.com>"> <span class="fn">José Fonseca</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Double delete in lp_bld_misc.cpp"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89387">bug 89387</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Double delete in lp_bld_misc.cpp"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89387#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Double delete in lp_bld_misc.cpp"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89387">bug 89387</a>
from <span class="vcard"><a class="email" href="mailto:jfonseca@vmware.com" title="José Fonseca <jfonseca@vmware.com>"> <span class="fn">José Fonseca</span></a>
</span></b>
<pre>(In reply to Chris Vine from <a href="show_bug.cgi?id=89387#c2">comment #2</a>)
<span class="quote">> That will work fine.</span >
Thanks.
<span class="quote">> This does beg the question whether the code is correct for llvm < 3.6 (it
> fixes llvm >= 3.6).</span >
I believe so.
LLVM 3.4 and 3.3's documentation for setMCJITMemoryManager/setJITMemoryManager
state they only take onwership if builder.create() is successful.
And indeed we only delete MM when builder.create() fails.
Fixed on
<a href="http://cgit.freedesktop.org/mesa/mesa/commit/?id=70dc8a9930f561d7ce6db7e58b5bc9b4d940e37b">http://cgit.freedesktop.org/mesa/mesa/commit/?id=70dc8a9930f561d7ce6db7e58b5bc9b4d940e37b</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>